| Message ID | 20250620-vd56g3_support-v1-3-df434bdbc9bd@foss.st.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series |
|
| Related | show |
Hi Benjamin, On Fri, 20 Jun 2025 at 14:50, Benjamin Mugnier <benjamin.mugnier@foss.st.com> wrote: > > Adapted from rpi cam_helper and tuning files. Values are sourced > initially from the vd56g3 user manual. > > Signed-off-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com> Reviewed-by: Naushir Patuck <naush@rasbperrypi.com> > --- > src/ipa/libipa/camera_sensor_helper.cpp | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp > index 7c66cd57d6857e43863375d0b32d688fb5a1063c..dcd69d9f2bbb39feabfefe41cee8b45f0f958127 100644 > --- a/src/ipa/libipa/camera_sensor_helper.cpp > +++ b/src/ipa/libipa/camera_sensor_helper.cpp > @@ -745,6 +745,18 @@ public: > }; > REGISTER_CAMERA_SENSOR_HELPER("ov13858", CameraSensorHelperOv13858) > > +class CameraSensorHelperVd56g3 : public CameraSensorHelper > +{ > +public: > + CameraSensorHelperVd56g3() > + { > + /* From datasheet: 0x40 at 10bits. */ > + blackLevel_ = 4096; > + gain_ = AnalogueGainLinear{ 0, 32, -1, 32 }; > + } > +}; > +REGISTER_CAMERA_SENSOR_HELPER("vd56g3", CameraSensorHelperVd56g3) > + > #endif /* __DOXYGEN__ */ > > } /* namespace ipa */ > > -- > 2.25.1 >
Hi Benjamin, Thank you for the patch. On Fri, Jun 20, 2025 at 03:49:18PM +0200, Benjamin Mugnier wrote: > Adapted from rpi cam_helper and tuning files. Values are sourced From the tuning files too ? I think you can drop this first sentence, the patch is just about describing the black level and gain model. With that, Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > initially from the vd56g3 user manual. > > Signed-off-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com> > --- > src/ipa/libipa/camera_sensor_helper.cpp | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp > index 7c66cd57d6857e43863375d0b32d688fb5a1063c..dcd69d9f2bbb39feabfefe41cee8b45f0f958127 100644 > --- a/src/ipa/libipa/camera_sensor_helper.cpp > +++ b/src/ipa/libipa/camera_sensor_helper.cpp > @@ -745,6 +745,18 @@ public: > }; > REGISTER_CAMERA_SENSOR_HELPER("ov13858", CameraSensorHelperOv13858) > > +class CameraSensorHelperVd56g3 : public CameraSensorHelper > +{ > +public: > + CameraSensorHelperVd56g3() > + { > + /* From datasheet: 0x40 at 10bits. */ > + blackLevel_ = 4096; > + gain_ = AnalogueGainLinear{ 0, 32, -1, 32 }; > + } > +}; > +REGISTER_CAMERA_SENSOR_HELPER("vd56g3", CameraSensorHelperVd56g3) > + > #endif /* __DOXYGEN__ */ > > } /* namespace ipa */
diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp index 7c66cd57d6857e43863375d0b32d688fb5a1063c..dcd69d9f2bbb39feabfefe41cee8b45f0f958127 100644 --- a/src/ipa/libipa/camera_sensor_helper.cpp +++ b/src/ipa/libipa/camera_sensor_helper.cpp @@ -745,6 +745,18 @@ public: }; REGISTER_CAMERA_SENSOR_HELPER("ov13858", CameraSensorHelperOv13858) +class CameraSensorHelperVd56g3 : public CameraSensorHelper +{ +public: + CameraSensorHelperVd56g3() + { + /* From datasheet: 0x40 at 10bits. */ + blackLevel_ = 4096; + gain_ = AnalogueGainLinear{ 0, 32, -1, 32 }; + } +}; +REGISTER_CAMERA_SENSOR_HELPER("vd56g3", CameraSensorHelperVd56g3) + #endif /* __DOXYGEN__ */ } /* namespace ipa */
Adapted from rpi cam_helper and tuning files. Values are sourced initially from the vd56g3 user manual. Signed-off-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com> --- src/ipa/libipa/camera_sensor_helper.cpp | 12 ++++++++++++ 1 file changed, 12 insertions(+)