| Message ID | 20250611013245.133785-16-bryan.odonoghue@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series |
|
| Related | show |
Hi Bryan, Bryan O'Donoghue <bryan.odonoghue@linaro.org> writes: > Add an element to the DebayerParams structure to capture the calculated > CCM. This allows us to pass the CCM into the eGL Debayer shader later on. > > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > --- > include/libcamera/internal/software_isp/debayer_params.h | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/include/libcamera/internal/software_isp/debayer_params.h b/include/libcamera/internal/software_isp/debayer_params.h > index 217cd5d9..56803195 100644 > --- a/include/libcamera/internal/software_isp/debayer_params.h > +++ b/include/libcamera/internal/software_isp/debayer_params.h > @@ -13,6 +13,8 @@ > #include <array> > #include <stdint.h> > > +#include "libcamera/internal/matrix.h" > + > namespace libcamera { > > struct DebayerParams { > @@ -49,6 +51,11 @@ struct DebayerParams { > CcmLookupTable greenCcm; > CcmLookupTable blueCcm; > LookupTable gammaLut; > + > + /* > + * Per frame CCM values as calcualted by the IPA s/calcualted/calculated/ And I think a one line comment can/should be formatted as /* ... */ With this fixed: Reviewed-by: Milan Zamazal <mzamazal@redhat.com> > + */ > + Matrix<float, 3, 3> ccm; > }; > > } /* namespace libcamera */
diff --git a/include/libcamera/internal/software_isp/debayer_params.h b/include/libcamera/internal/software_isp/debayer_params.h index 217cd5d9..56803195 100644 --- a/include/libcamera/internal/software_isp/debayer_params.h +++ b/include/libcamera/internal/software_isp/debayer_params.h @@ -13,6 +13,8 @@ #include <array> #include <stdint.h> +#include "libcamera/internal/matrix.h" + namespace libcamera { struct DebayerParams { @@ -49,6 +51,11 @@ struct DebayerParams { CcmLookupTable greenCcm; CcmLookupTable blueCcm; LookupTable gammaLut; + + /* + * Per frame CCM values as calcualted by the IPA + */ + Matrix<float, 3, 3> ccm; }; } /* namespace libcamera */
Add an element to the DebayerParams structure to capture the calculated CCM. This allows us to pass the CCM into the eGL Debayer shader later on. Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> --- include/libcamera/internal/software_isp/debayer_params.h | 7 +++++++ 1 file changed, 7 insertions(+)