[14/35] libcamera: software_isp: debayer: Make the debayer_ object of type class Debayer not DebayerCpu
diff mbox series

Message ID 20250611013245.133785-15-bryan.odonoghue@linaro.org
State New
Headers show
Series
  • Add GLES 2.0 GPUISP to libcamera
Related show

Commit Message

Bryan O'Donoghue June 11, 2025, 1:32 a.m. UTC
Make the type of object Debayer not DebayerCpu thus allowing us to assign
the object to either DebayerCpu or DebayerEGL.

Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
 include/libcamera/internal/software_isp/software_isp.h | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Comments

Milan Zamazal June 17, 2025, 11:27 a.m. UTC | #1
Bryan O'Donoghue <bryan.odonoghue@linaro.org> writes:

> Make the type of object Debayer not DebayerCpu thus allowing us to assign
> the object to either DebayerCpu or DebayerEGL.
>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>

Reviewed-by: Milan Zamazal <mzamazal@redhat.com>

> ---
>  include/libcamera/internal/software_isp/software_isp.h | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/include/libcamera/internal/software_isp/software_isp.h b/include/libcamera/internal/software_isp/software_isp.h
> index 78624659..ad89c9b3 100644
> --- a/include/libcamera/internal/software_isp/software_isp.h
> +++ b/include/libcamera/internal/software_isp/software_isp.h
> @@ -37,7 +37,7 @@
>  
>  namespace libcamera {
>  
> -class DebayerCpu;
> +class Debayer;
>  class FrameBuffer;
>  class PixelFormat;
>  class Stream;
> @@ -94,8 +94,7 @@ private:
>  	void statsReady(uint32_t frame, uint32_t bufferId);
>  	void inputReady(FrameBuffer *input);
>  	void outputReady(FrameBuffer *output);
> -
> -	std::unique_ptr<DebayerCpu> debayer_;
> +	std::unique_ptr<Debayer> debayer_;
>  	Thread ispWorkerThread_;
>  	SharedMemObject<DebayerParams> sharedParams_;
>  	DebayerParams debayerParams_;

Patch
diff mbox series

diff --git a/include/libcamera/internal/software_isp/software_isp.h b/include/libcamera/internal/software_isp/software_isp.h
index 78624659..ad89c9b3 100644
--- a/include/libcamera/internal/software_isp/software_isp.h
+++ b/include/libcamera/internal/software_isp/software_isp.h
@@ -37,7 +37,7 @@ 
 
 namespace libcamera {
 
-class DebayerCpu;
+class Debayer;
 class FrameBuffer;
 class PixelFormat;
 class Stream;
@@ -94,8 +94,7 @@  private:
 	void statsReady(uint32_t frame, uint32_t bufferId);
 	void inputReady(FrameBuffer *input);
 	void outputReady(FrameBuffer *output);
-
-	std::unique_ptr<DebayerCpu> debayer_;
+	std::unique_ptr<Debayer> debayer_;
 	Thread ispWorkerThread_;
 	SharedMemObject<DebayerParams> sharedParams_;
 	DebayerParams debayerParams_;