[2/2] pipeline: imx8-isi: Fix match returned value in error case
diff mbox series

Message ID 20250604131403.1729356-2-antoine.bouyer@nxp.com
State New
Headers show
Series
  • [1/2] pipeline: imx8-isi: Cosmetic changes
Related show

Commit Message

Antoine Bouyer June 4, 2025, 1:14 p.m. UTC 
Match callback returns boolean type, while it could return int in case
of error when opening the capture file.
Fixes: 0ec982d2108 ("libcamera: pipeline: Add IMX8 ISI pipeline")

Signed-off-by: Antoine Bouyer <antoine.bouyer@nxp.com>
---
 src/libcamera/pipeline/imx8-isi/imx8-isi.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Barnabás Pőcze June 4, 2025, 1:17 p.m. UTC | #1 
Hi

2025. 06. 04. 15:14 keltezéssel, Antoine Bouyer írta:
> Match callback returns boolean type, while it could return int in case
> of error when opening the capture file.
> Fixes: 0ec982d2108 ("libcamera: pipeline: Add IMX8 ISI pipeline")
> 
> Signed-off-by: Antoine Bouyer <antoine.bouyer@nxp.com>

Reviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>


Regards,
Barnabás Pőcze


> ---
>   src/libcamera/pipeline/imx8-isi/imx8-isi.cpp | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp b/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp
> index dc20ab2..1b7c661 100644
> --- a/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp
> +++ b/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp
> @@ -1003,7 +1003,7 @@ bool PipelineHandlerISI::match(DeviceEnumerator *enumerator)
>   
>   		ret = capture->open();
>   		if (ret)
> -			return ret;
> +			return false;
>   
>   		pipes_.push_back({ std::move(isi), std::move(capture) });
>   	}
Laurent Pinchart June 4, 2025, 1:23 p.m. UTC | #2 
Hi Antoine,

Thank you for the patch.

On Wed, Jun 04, 2025 at 03:14:03PM +0200, Antoine Bouyer wrote:
> Match callback returns boolean type, while it could return int in case

"The match() function returns a boolean type, ..."

> of error when opening the capture file.

Missing blank line.

> Fixes: 0ec982d2108 ("libcamera: pipeline: Add IMX8 ISI pipeline")
> 

No blank line here.

> Signed-off-by: Antoine Bouyer <antoine.bouyer@nxp.com>

No need to resubmit this patch either.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  src/libcamera/pipeline/imx8-isi/imx8-isi.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp b/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp
> index dc20ab2..1b7c661 100644
> --- a/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp
> +++ b/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp
> @@ -1003,7 +1003,7 @@ bool PipelineHandlerISI::match(DeviceEnumerator *enumerator)
>  
>  		ret = capture->open();
>  		if (ret)
> -			return ret;
> +			return false;
>  
>  		pipes_.push_back({ std::move(isi), std::move(capture) });
>  	}
Laurent Pinchart June 4, 2025, 1:40 p.m. UTC | #3 
On Wed, Jun 04, 2025 at 04:23:27PM +0300, Laurent Pinchart wrote:
> Hi Antoine,
> 
> Thank you for the patch.
> 
> On Wed, Jun 04, 2025 at 03:14:03PM +0200, Antoine Bouyer wrote:
> > Match callback returns boolean type, while it could return int in case
> 
> "The match() function returns a boolean type, ..."
> 
> > of error when opening the capture file.
> 
> Missing blank line.
> 
> > Fixes: 0ec982d2108 ("libcamera: pipeline: Add IMX8 ISI pipeline")

Also, this should be 

Fixes: 0ec982d21086 ("libcamera: pipeline: Add IMX8 ISI pipeline")

I have the following in my ~/.bashrc:

--------
gpf() {
        git show --pretty=fixes -s ${1:-HEAD} | wl-copy
}
--------

(you can replace "wl-copy" with "xclip -selection clipboard" if you use
X instead of Wayland)

and the following in my ~/.gitconfig:

--------
[core]
        abbrev = 12

[pretty]
        fixes = Fixes: %h (\"%s\")
--------

That way I can run "gpf 0ec982d210861cc6aaebb5d6e8f1a755a16c9792" and
then press ctrl-shift-v (or whatever the paste shortcut is in your
editor) and get

Fixes: 0ec982d21086 ("libcamera: pipeline: Add IMX8 ISI pipeline")

> > 
> 
> No blank line here.
> 
> > Signed-off-by: Antoine Bouyer <antoine.bouyer@nxp.com>
> 
> No need to resubmit this patch either.
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> 
> > ---
> >  src/libcamera/pipeline/imx8-isi/imx8-isi.cpp | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp b/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp
> > index dc20ab2..1b7c661 100644
> > --- a/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp
> > +++ b/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp
> > @@ -1003,7 +1003,7 @@ bool PipelineHandlerISI::match(DeviceEnumerator *enumerator)
> >  
> >  		ret = capture->open();
> >  		if (ret)
> > -			return ret;
> > +			return false;
> >  
> >  		pipes_.push_back({ std::move(isi), std::move(capture) });
> >  	}

Patch
diff mbox series 

diff --git a/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp b/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp
index dc20ab2..1b7c661 100644
--- a/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp
+++ b/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp
@@ -1003,7 +1003,7 @@  bool PipelineHandlerISI::match(DeviceEnumerator *enumerator)
 
 		ret = capture->open();
 		if (ret)
-			return ret;
+			return false;
 
 		pipes_.push_back({ std::move(isi), std::move(capture) });
 	}