Message ID | 20250603134535.772886-1-barnabas.pocze@ideasonboard.com |
---|---|
State | Accepted |
Headers | show |
Series |
|
Related | show |
On Tue, Jun 03, 2025 at 03:45:35PM +0200, Barnabás Pőcze wrote: > The default argument already takes care of passing no fence to > `addBuffer()`, so there is no reason to specify `nullptr` explicitly. > > Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com> > --- > src/android/camera_device.cpp | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp > index a038131ae..5dfa1fe22 100644 > --- a/src/android/camera_device.cpp > +++ b/src/android/camera_device.cpp > @@ -1078,8 +1078,7 @@ int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Reques > FrameBuffer *frameBuffer = cameraStream->getBuffer(); > buffer.internalBuffer = frameBuffer; > > - descriptor->request_->addBuffer(sourceStream->stream(), > - frameBuffer, nullptr); > + descriptor->request_->addBuffer(sourceStream->stream(), frameBuffer); I'd keep the original line wrap. Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > requestedStreams.insert(sourceStream); > }
Quoting Laurent Pinchart (2025-06-03 14:57:17) > On Tue, Jun 03, 2025 at 03:45:35PM +0200, Barnabás Pőcze wrote: > > The default argument already takes care of passing no fence to > > `addBuffer()`, so there is no reason to specify `nullptr` explicitly. > > > > Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com> > > --- > > src/android/camera_device.cpp | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp > > index a038131ae..5dfa1fe22 100644 > > --- a/src/android/camera_device.cpp > > +++ b/src/android/camera_device.cpp > > @@ -1078,8 +1078,7 @@ int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Reques > > FrameBuffer *frameBuffer = cameraStream->getBuffer(); > > buffer.internalBuffer = frameBuffer; > > > > - descriptor->request_->addBuffer(sourceStream->stream(), > > - frameBuffer, nullptr); > > + descriptor->request_->addBuffer(sourceStream->stream(), frameBuffer); > > I'd keep the original line wrap. > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Cleaner without the nullptr indeed. Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > > > > > requestedStreams.insert(sourceStream); > > } > > -- > Regards, > > Laurent Pinchart
diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp index a038131ae..5dfa1fe22 100644 --- a/src/android/camera_device.cpp +++ b/src/android/camera_device.cpp @@ -1078,8 +1078,7 @@ int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Reques FrameBuffer *frameBuffer = cameraStream->getBuffer(); buffer.internalBuffer = frameBuffer; - descriptor->request_->addBuffer(sourceStream->stream(), - frameBuffer, nullptr); + descriptor->request_->addBuffer(sourceStream->stream(), frameBuffer); requestedStreams.insert(sourceStream); }
The default argument already takes care of passing no fence to `addBuffer()`, so there is no reason to specify `nullptr` explicitly. Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com> --- src/android/camera_device.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)