| Message ID | 20250528121827.87844-2-niklas.soderlund@ragnatech.se |
|---|---|
| State | New |
| Headers | show |
| Series |
|
| Related | show |
Hi Niklas On 28/05/2025 13:18, Niklas Söderlund wrote: > The private function cio2BufferReady is defined but not implemented or > used, remove it for the class definition. > > Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se> > --- Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com> > src/libcamera/pipeline/ipu3/cio2.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/src/libcamera/pipeline/ipu3/cio2.h b/src/libcamera/pipeline/ipu3/cio2.h > index 963c2f6b93a4..3aa3a1ca8ef8 100644 > --- a/src/libcamera/pipeline/ipu3/cio2.h > +++ b/src/libcamera/pipeline/ipu3/cio2.h > @@ -66,8 +66,6 @@ public: > private: > void freeBuffers(); > > - void cio2BufferReady(FrameBuffer *buffer); > - > std::unique_ptr<CameraSensor> sensor_; > std::unique_ptr<V4L2Subdevice> csi2_; > std::unique_ptr<V4L2VideoDevice> output_;
On Wed, May 28, 2025 at 01:22:02PM +0100, Daniel Scally wrote: > On 28/05/2025 13:18, Niklas Söderlund wrote: > > The private function cio2BufferReady is defined but not implemented or > > used, remove it for the class definition. > > > > Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se> > > --- > > Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > src/libcamera/pipeline/ipu3/cio2.h | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/src/libcamera/pipeline/ipu3/cio2.h b/src/libcamera/pipeline/ipu3/cio2.h > > index 963c2f6b93a4..3aa3a1ca8ef8 100644 > > --- a/src/libcamera/pipeline/ipu3/cio2.h > > +++ b/src/libcamera/pipeline/ipu3/cio2.h > > @@ -66,8 +66,6 @@ public: > > private: > > void freeBuffers(); > > > > - void cio2BufferReady(FrameBuffer *buffer); > > - > > std::unique_ptr<CameraSensor> sensor_; > > std::unique_ptr<V4L2Subdevice> csi2_; > > std::unique_ptr<V4L2VideoDevice> output_;
diff --git a/src/libcamera/pipeline/ipu3/cio2.h b/src/libcamera/pipeline/ipu3/cio2.h index 963c2f6b93a4..3aa3a1ca8ef8 100644 --- a/src/libcamera/pipeline/ipu3/cio2.h +++ b/src/libcamera/pipeline/ipu3/cio2.h @@ -66,8 +66,6 @@ public: private: void freeBuffers(); - void cio2BufferReady(FrameBuffer *buffer); - std::unique_ptr<CameraSensor> sensor_; std::unique_ptr<V4L2Subdevice> csi2_; std::unique_ptr<V4L2VideoDevice> output_;
The private function cio2BufferReady is defined but not implemented or used, remove it for the class definition. Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se> --- src/libcamera/pipeline/ipu3/cio2.h | 2 -- 1 file changed, 2 deletions(-)