[libcamera-devel,v2,07/10] libcamera: pipeline_handler: Do not use argument as local variable
diff mbox series

Message ID 20191120015506.362440-8-niklas.soderlund@ragnatech.se
State Accepted
Headers show
Series
  • libcamera: Fixes found while working on new
Related show

Commit Message

Niklas Söderlund Nov. 20, 2019, 1:55 a.m. UTC 
In completeRequest() the request argument is used as a local variable,
this is confusing. Add a separate local variable instead of reusing the
argument.

Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 src/libcamera/pipeline_handler.cpp | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Patch
diff mbox series 

diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp
index 884feaa6ecbd4851..4349ca8957e403fe 100644
--- a/src/libcamera/pipeline_handler.cpp
+++ b/src/libcamera/pipeline_handler.cpp
@@ -409,13 +409,13 @@  void PipelineHandler::completeRequest(Camera *camera, Request *request)
 	CameraData *data = cameraData(camera);
 
 	while (!data->queuedRequests_.empty()) {
-		request = data->queuedRequests_.front();
-		if (request->status() == Request::RequestPending)
+		Request *req = data->queuedRequests_.front();
+		if (req->status() == Request::RequestPending)
 			break;
 
-		ASSERT(!request->hasPendingBuffers());
+		ASSERT(!req->hasPendingBuffers());
 		data->queuedRequests_.pop_front();
-		camera->requestComplete(request);
+		camera->requestComplete(req);
 	}
 }