[v1,1/2] libcamera: converter_v4l2_m2m: Add missing `<set>` include
diff mbox series

Message ID 20250515123039.3134682-1-barnabas.pocze@ideasonboard.com
State Superseded
Headers show
Series
  • [v1,1/2] libcamera: converter_v4l2_m2m: Add missing `<set>` include
Related show

Commit Message

Barnabás Pőcze May 15, 2025, 12:30 p.m. UTC
`std::set` is directly used in the file, but not directly included.

Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
---
 src/libcamera/converter/converter_v4l2_m2m.cpp | 1 +
 1 file changed, 1 insertion(+)

Comments

Paul Elder May 15, 2025, 12:56 p.m. UTC | #1
Quoting Barnabás Pőcze (2025-05-15 14:30:38)
> `std::set` is directly used in the file, but not directly included.
> 
> Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>

Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>

> ---
>  src/libcamera/converter/converter_v4l2_m2m.cpp | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/libcamera/converter/converter_v4l2_m2m.cpp b/src/libcamera/converter/converter_v4l2_m2m.cpp
> index ee05b798f..0ce7a7a67 100644
> --- a/src/libcamera/converter/converter_v4l2_m2m.cpp
> +++ b/src/libcamera/converter/converter_v4l2_m2m.cpp
> @@ -10,6 +10,7 @@
>  
>  #include <algorithm>
>  #include <limits.h>
> +#include <set>
>  
>  #include <libcamera/base/log.h>
>  #include <libcamera/base/signal.h>
> -- 
> 2.49.0
>
Kieran Bingham May 16, 2025, 12:37 p.m. UTC | #2
Quoting Paul Elder (2025-05-15 13:56:02)
> Quoting Barnabás Pőcze (2025-05-15 14:30:38)
> > `std::set` is directly used in the file, but not directly included.
> > 
> > Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
> 
> Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> 
> > ---
> >  src/libcamera/converter/converter_v4l2_m2m.cpp | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/src/libcamera/converter/converter_v4l2_m2m.cpp b/src/libcamera/converter/converter_v4l2_m2m.cpp
> > index ee05b798f..0ce7a7a67 100644
> > --- a/src/libcamera/converter/converter_v4l2_m2m.cpp
> > +++ b/src/libcamera/converter/converter_v4l2_m2m.cpp
> > @@ -10,6 +10,7 @@
> >  
> >  #include <algorithm>
> >  #include <limits.h>
> > +#include <set>
> >  
> >  #include <libcamera/base/log.h>
> >  #include <libcamera/base/signal.h>
> > -- 
> > 2.49.0
> >

Patch
diff mbox series

diff --git a/src/libcamera/converter/converter_v4l2_m2m.cpp b/src/libcamera/converter/converter_v4l2_m2m.cpp
index ee05b798f..0ce7a7a67 100644
--- a/src/libcamera/converter/converter_v4l2_m2m.cpp
+++ b/src/libcamera/converter/converter_v4l2_m2m.cpp
@@ -10,6 +10,7 @@ 
 
 #include <algorithm>
 #include <limits.h>
+#include <set>
 
 #include <libcamera/base/log.h>
 #include <libcamera/base/signal.h>