| Message ID | 20250510090713.7114-1-kieran.bingham@ideasonboard.com |
|---|---|
| State | Accepted |
| Commit | 37dccb4584346b53b0f39184bb3a71eed9ca8d6c |
| Headers | show |
| Series |
|
| Related | show |
Hi Kieran, Thank you for the patch! On Sat, 2025-05-10 at 11:07 +0200, Kieran Bingham wrote: > IPAs are expected to live within a directory that is searched by the > IPAManager. If other non-IPA so files are installed in the same > location, then the user may be presented with an error message > reporting > that the module could not be parsed. > > Move IPA modules to an ipa specific subdirectory to ensure we only > parse > .so files that are expected to be IPA modules at load time. > > Bug: https://bugs.libcamera.org/show_bug.cgi?id=268 > Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > --- > src/ipa/meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/ipa/meson.build b/src/ipa/meson.build > index 0ad4631def27..68f64b9a6fa3 100644 > --- a/src/ipa/meson.build > +++ b/src/ipa/meson.build > @@ -4,7 +4,7 @@ ipa_includes = [ > libcamera_includes, > ] > > -ipa_install_dir = libcamera_libdir > +ipa_install_dir = libcamera_libdir / 'ipa' > ipa_data_dir = libcamera_datadir / 'ipa' > ipa_sysconf_dir = libcamera_sysconfdir / 'ipa' Reviewed-by: Isaac Scott <isaac.scott@ideasonboard.com> >
Hi Kieran, Thank you for the patch. On Sat, May 10, 2025 at 11:07:13AM +0200, Kieran Bingham wrote: > IPAs are expected to live within a directory that is searched by the > IPAManager. If other non-IPA so files are installed in the same > location, then the user may be presented with an error message reporting > that the module could not be parsed. > > Move IPA modules to an ipa specific subdirectory to ensure we only parse > .so files that are expected to be IPA modules at load time. > > Bug: https://bugs.libcamera.org/show_bug.cgi?id=268 > Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > src/ipa/meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/ipa/meson.build b/src/ipa/meson.build > index 0ad4631def27..68f64b9a6fa3 100644 > --- a/src/ipa/meson.build > +++ b/src/ipa/meson.build > @@ -4,7 +4,7 @@ ipa_includes = [ > libcamera_includes, > ] > > -ipa_install_dir = libcamera_libdir > +ipa_install_dir = libcamera_libdir / 'ipa' > ipa_data_dir = libcamera_datadir / 'ipa' > ipa_sysconf_dir = libcamera_sysconfdir / 'ipa' >
Quoting Kieran Bingham (2025-05-10 11:07:13) > IPAs are expected to live within a directory that is searched by the > IPAManager. If other non-IPA so files are installed in the same > location, then the user may be presented with an error message reporting > that the module could not be parsed. > > Move IPA modules to an ipa specific subdirectory to ensure we only parse > .so files that are expected to be IPA modules at load time. > > Bug: https://bugs.libcamera.org/show_bug.cgi?id=268 > Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com> Reviewed-by: Paul Elder <paul.elder@ideasonboard.com> > --- > src/ipa/meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/ipa/meson.build b/src/ipa/meson.build > index 0ad4631def27..68f64b9a6fa3 100644 > --- a/src/ipa/meson.build > +++ b/src/ipa/meson.build > @@ -4,7 +4,7 @@ ipa_includes = [ > libcamera_includes, > ] > > -ipa_install_dir = libcamera_libdir > +ipa_install_dir = libcamera_libdir / 'ipa' > ipa_data_dir = libcamera_datadir / 'ipa' > ipa_sysconf_dir = libcamera_sysconfdir / 'ipa' > > -- > 2.49.0 >
diff --git a/src/ipa/meson.build b/src/ipa/meson.build index 0ad4631def27..68f64b9a6fa3 100644 --- a/src/ipa/meson.build +++ b/src/ipa/meson.build @@ -4,7 +4,7 @@ ipa_includes = [ libcamera_includes, ] -ipa_install_dir = libcamera_libdir +ipa_install_dir = libcamera_libdir / 'ipa' ipa_data_dir = libcamera_datadir / 'ipa' ipa_sysconf_dir = libcamera_sysconfdir / 'ipa'
IPAs are expected to live within a directory that is searched by the IPAManager. If other non-IPA so files are installed in the same location, then the user may be presented with an error message reporting that the module could not be parsed. Move IPA modules to an ipa specific subdirectory to ensure we only parse .so files that are expected to be IPA modules at load time. Bug: https://bugs.libcamera.org/show_bug.cgi?id=268 Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com> --- src/ipa/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)