[v1] Documentation: guides: application-developer: Remove unnecessary argument
diff mbox series

Message ID 20250502151330.192877-1-barnabas.pocze@ideasonboard.com
State Accepted
Commit 2f62701e9e714785cf7063da7720a56a73cac02a
Headers show
Series
  • [v1] Documentation: guides: application-developer: Remove unnecessary argument
Related show

Commit Message

Barnabás Pőcze May 2, 2025, 3:13 p.m. UTC
`required: true` is the default for meson's `dependency()` function.

Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
---
 Documentation/guides/application-developer.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Laurent Pinchart May 2, 2025, 3:20 p.m. UTC | #1
On Fri, May 02, 2025 at 05:13:30PM +0200, Barnabás Pőcze wrote:
> `required: true` is the default for meson's `dependency()` function.
> 
> Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  Documentation/guides/application-developer.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/guides/application-developer.rst b/Documentation/guides/application-developer.rst
> index 3608598e0..2d7c29010 100644
> --- a/Documentation/guides/application-developer.rst
> +++ b/Documentation/guides/application-developer.rst
> @@ -626,7 +626,7 @@ accordingly. In this example, the application file has been named
>  
>     simple_cam = executable('simple-cam',
>         'simple-cam.cpp',
> -       dependencies: dependency('libcamera', required : true))
> +       dependencies: dependency('libcamera'))
>  
>  The ``dependencies`` line instructs meson to ask ``pkgconfig`` (or ``cmake``) to
>  locate the ``libcamera`` library,  which the test application will be
Kieran Bingham May 3, 2025, 6:54 p.m. UTC | #2
Quoting Laurent Pinchart (2025-05-02 16:20:19)
> On Fri, May 02, 2025 at 05:13:30PM +0200, Barnabás Pőcze wrote:
> > `required: true` is the default for meson's `dependency()` function.
> > 
> > Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> 

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> > ---
> >  Documentation/guides/application-developer.rst | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/guides/application-developer.rst b/Documentation/guides/application-developer.rst
> > index 3608598e0..2d7c29010 100644
> > --- a/Documentation/guides/application-developer.rst
> > +++ b/Documentation/guides/application-developer.rst
> > @@ -626,7 +626,7 @@ accordingly. In this example, the application file has been named
> >  
> >     simple_cam = executable('simple-cam',
> >         'simple-cam.cpp',
> > -       dependencies: dependency('libcamera', required : true))
> > +       dependencies: dependency('libcamera'))
> >  
> >  The ``dependencies`` line instructs meson to ask ``pkgconfig`` (or ``cmake``) to
> >  locate the ``libcamera`` library,  which the test application will be
> 
> -- 
> Regards,
> 
> Laurent Pinchart

Patch
diff mbox series

diff --git a/Documentation/guides/application-developer.rst b/Documentation/guides/application-developer.rst
index 3608598e0..2d7c29010 100644
--- a/Documentation/guides/application-developer.rst
+++ b/Documentation/guides/application-developer.rst
@@ -626,7 +626,7 @@  accordingly. In this example, the application file has been named
 
    simple_cam = executable('simple-cam',
        'simple-cam.cpp',
-       dependencies: dependency('libcamera', required : true))
+       dependencies: dependency('libcamera'))
 
 The ``dependencies`` line instructs meson to ask ``pkgconfig`` (or ``cmake``) to
 locate the ``libcamera`` library,  which the test application will be