| Message ID | 20250421064959.1239069-1-paul.elder@ideasonboard.com |
|---|---|
| State | Accepted |
| Commit | 86c45c8fdf36b6983ad0d585184218f541bb4fd5 |
| Headers | show |
| Series |
|
| Related | show |
Quoting Paul Elder (2025-04-21 07:49:59) > The vblank delay for delayed controls was incorrectly hardcoded to 1. > Get it from the camera sensor properties instead. > > Fixes: f72c76eb6e06 ("rkisp1: Honor the FrameDurationLimits control") > Signed-off-by: Paul Elder <paul.elder@ideasonboard.com> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > --- > src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp > index 52633fe3cb85..194dfce7ee5d 100644 > --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp > +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp > @@ -1325,7 +1325,7 @@ int PipelineHandlerRkISP1::createCamera(MediaEntity *sensor) > std::unordered_map<uint32_t, DelayedControls::ControlParams> params = { > { V4L2_CID_ANALOGUE_GAIN, { delays.gainDelay, false } }, > { V4L2_CID_EXPOSURE, { delays.exposureDelay, false } }, > - { V4L2_CID_VBLANK, { 1, false } }, > + { V4L2_CID_VBLANK, { delays.vblankDelay, false } }, > }; > > data->delayedCtrls_ = > -- > 2.47.2 >
Hi Paul, Thank you for the patch. On Mon, Apr 21, 2025 at 03:49:59PM +0900, Paul Elder wrote: > The vblank delay for delayed controls was incorrectly hardcoded to 1. > Get it from the camera sensor properties instead. > > Fixes: f72c76eb6e06 ("rkisp1: Honor the FrameDurationLimits control") > Signed-off-by: Paul Elder <paul.elder@ideasonboard.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp > index 52633fe3cb85..194dfce7ee5d 100644 > --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp > +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp > @@ -1325,7 +1325,7 @@ int PipelineHandlerRkISP1::createCamera(MediaEntity *sensor) > std::unordered_map<uint32_t, DelayedControls::ControlParams> params = { > { V4L2_CID_ANALOGUE_GAIN, { delays.gainDelay, false } }, > { V4L2_CID_EXPOSURE, { delays.exposureDelay, false } }, > - { V4L2_CID_VBLANK, { 1, false } }, > + { V4L2_CID_VBLANK, { delays.vblankDelay, false } }, > }; > > data->delayedCtrls_ =
diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp index 52633fe3cb85..194dfce7ee5d 100644 --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp @@ -1325,7 +1325,7 @@ int PipelineHandlerRkISP1::createCamera(MediaEntity *sensor) std::unordered_map<uint32_t, DelayedControls::ControlParams> params = { { V4L2_CID_ANALOGUE_GAIN, { delays.gainDelay, false } }, { V4L2_CID_EXPOSURE, { delays.exposureDelay, false } }, - { V4L2_CID_VBLANK, { 1, false } }, + { V4L2_CID_VBLANK, { delays.vblankDelay, false } }, }; data->delayedCtrls_ =
The vblank delay for delayed controls was incorrectly hardcoded to 1. Get it from the camera sensor properties instead. Fixes: f72c76eb6e06 ("rkisp1: Honor the FrameDurationLimits control") Signed-off-by: Paul Elder <paul.elder@ideasonboard.com> --- src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)