| Message ID | 20250418162405.1339989-1-barnabas.pocze@ideasonboard.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series |
|
| Related | show |
Quoting Barnabás Pőcze (2025-04-18 17:24:05) > The `mbusCodes` variable in `ISICameraConfiguration::validateRaw()` > has been unused since > > 87fed432533a ("libcamera: imx8-isi: Break out RAW format selection"), > > so remove it. > > Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > --- > src/libcamera/pipeline/imx8-isi/imx8-isi.cpp | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp b/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp > index 4e66b3368..ecda426a6 100644 > --- a/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp > +++ b/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp > @@ -366,7 +366,6 @@ ISICameraConfiguration::validateRaw(std::set<Stream *> &availableStreams, > * Make sure the requested RAW format is supported by the > * pipeline, otherwise adjust it. > */ > - std::vector<unsigned int> mbusCodes = data_->sensor_->mbusCodes(); > StreamConfiguration &rawConfig = config_[0]; > PixelFormat rawFormat = rawConfig.pixelFormat; > > -- > 2.49.0 >
On Fri, Apr 18, 2025 at 05:48:08PM +0100, Kieran Bingham wrote: > Quoting Barnabás Pőcze (2025-04-18 17:24:05) > > The `mbusCodes` variable in `ISICameraConfiguration::validateRaw()` > > has been unused since > > > > 87fed432533a ("libcamera: imx8-isi: Break out RAW format selection"), > > > > so remove it. > > > > Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com> > > Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > --- > > src/libcamera/pipeline/imx8-isi/imx8-isi.cpp | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp b/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp > > index 4e66b3368..ecda426a6 100644 > > --- a/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp > > +++ b/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp > > @@ -366,7 +366,6 @@ ISICameraConfiguration::validateRaw(std::set<Stream *> &availableStreams, > > * Make sure the requested RAW format is supported by the > > * pipeline, otherwise adjust it. > > */ > > - std::vector<unsigned int> mbusCodes = data_->sensor_->mbusCodes(); > > StreamConfiguration &rawConfig = config_[0]; > > PixelFormat rawFormat = rawConfig.pixelFormat; > >
diff --git a/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp b/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp index 4e66b3368..ecda426a6 100644 --- a/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp +++ b/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp @@ -366,7 +366,6 @@ ISICameraConfiguration::validateRaw(std::set<Stream *> &availableStreams, * Make sure the requested RAW format is supported by the * pipeline, otherwise adjust it. */ - std::vector<unsigned int> mbusCodes = data_->sensor_->mbusCodes(); StreamConfiguration &rawConfig = config_[0]; PixelFormat rawFormat = rawConfig.pixelFormat;
The `mbusCodes` variable in `ISICameraConfiguration::validateRaw()` has been unused since 87fed432533a ("libcamera: imx8-isi: Break out RAW format selection"), so remove it. Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com> --- src/libcamera/pipeline/imx8-isi/imx8-isi.cpp | 1 - 1 file changed, 1 deletion(-)