[v1] libcamera: pipeline: virtual: Fix typo in log message
diff mbox series

Message ID 20250418162359.1339957-1-barnabas.pocze@ideasonboard.com
State Accepted
Headers show
Series
  • [v1] libcamera: pipeline: virtual: Fix typo in log message
Related show

Commit Message

Barnabás Pőcze April 18, 2025, 4:23 p.m. UTC 
pass -> parse

Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
---
 src/libcamera/pipeline/virtual/config_parser.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kieran Bingham April 18, 2025, 4:27 p.m. UTC | #1 
Quoting Barnabás Pőcze (2025-04-18 17:23:59)
> pass -> parse

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

I think you can merge that straight away.

> Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
> ---
>  src/libcamera/pipeline/virtual/config_parser.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/libcamera/pipeline/virtual/config_parser.cpp b/src/libcamera/pipeline/virtual/config_parser.cpp
> index 1e009946d..d9900add6 100644
> --- a/src/libcamera/pipeline/virtual/config_parser.cpp
> +++ b/src/libcamera/pipeline/virtual/config_parser.cpp
> @@ -31,7 +31,7 @@ ConfigParser::parseConfigFile(File &file, PipelineHandler *pipe)
>  
>         std::unique_ptr<YamlObject> cameras = YamlParser::parse(file);
>         if (!cameras) {
> -               LOG(Virtual, Error) << "Failed to pass config file.";
> +               LOG(Virtual, Error) << "Failed to parse config file.";
>                 return configurations;
>         }
>  
> -- 
> 2.49.0
>
Laurent Pinchart April 21, 2025, 2:04 p.m. UTC | #2 
On Fri, Apr 18, 2025 at 05:27:38PM +0100, Kieran Bingham wrote:
> Quoting Barnabás Pőcze (2025-04-18 17:23:59)
> > pass -> parse
> 
> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
> 
> I think you can merge that straight away.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> > Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
> > ---
> >  src/libcamera/pipeline/virtual/config_parser.cpp | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/src/libcamera/pipeline/virtual/config_parser.cpp b/src/libcamera/pipeline/virtual/config_parser.cpp
> > index 1e009946d..d9900add6 100644
> > --- a/src/libcamera/pipeline/virtual/config_parser.cpp
> > +++ b/src/libcamera/pipeline/virtual/config_parser.cpp
> > @@ -31,7 +31,7 @@ ConfigParser::parseConfigFile(File &file, PipelineHandler *pipe)
> >  
> >         std::unique_ptr<YamlObject> cameras = YamlParser::parse(file);
> >         if (!cameras) {
> > -               LOG(Virtual, Error) << "Failed to pass config file.";
> > +               LOG(Virtual, Error) << "Failed to parse config file.";
> >                 return configurations;
> >         }
> >

Patch
diff mbox series 

diff --git a/src/libcamera/pipeline/virtual/config_parser.cpp b/src/libcamera/pipeline/virtual/config_parser.cpp
index 1e009946d..d9900add6 100644
--- a/src/libcamera/pipeline/virtual/config_parser.cpp
+++ b/src/libcamera/pipeline/virtual/config_parser.cpp
@@ -31,7 +31,7 @@  ConfigParser::parseConfigFile(File &file, PipelineHandler *pipe)
 
 	std::unique_ptr<YamlObject> cameras = YamlParser::parse(file);
 	if (!cameras) {
-		LOG(Virtual, Error) << "Failed to pass config file.";
+		LOG(Virtual, Error) << "Failed to parse config file.";
 		return configurations;
 	}