[2/8] tuning: rksip1: Add a static WideDynamicRange entry
diff mbox series

Message ID 20250411130423.2164577-3-stefan.klug@ideasonboard.com
State New
Headers show
Series
  • Implement WDR algorithm
Related show

Commit Message

Stefan Klug April 11, 2025, 1:04 p.m. UTC
Add a static WideDynamicRange entry that gets added by default.

Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>
---
 utils/tuning/rkisp1.py | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

Comments

Paul Elder May 12, 2025, 9:26 a.m. UTC | #1
Quoting Stefan Klug (2025-04-11 15:04:09)
> Add a static WideDynamicRange entry that gets added by default.
> 
> Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>

Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>

> ---
>  utils/tuning/rkisp1.py | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/utils/tuning/rkisp1.py b/utils/tuning/rkisp1.py
> index 207b717a029c..1c9261021922 100755
> --- a/utils/tuning/rkisp1.py
> +++ b/utils/tuning/rkisp1.py
> @@ -47,15 +47,18 @@ lsc = LSCRkISP1(debug=[lt.Debug.Plot],
>                  # values.  This can also be a custom function.
>                  smoothing_function=lt.smoothing.MedianBlur(3),)
>  lux = LuxRkISP1(debug=[lt.Debug.Plot])
> +wdr = StaticModule('WideDynamicRange',
> +                   { 'ExposureConstraint': { 'MaxBrightPixels': 0.02, 'yTarget': 0.95 },
> +                     'MinExposureValue': -4.0 })
>  
>  tuner = lt.Tuner('RkISP1')
> -tuner.add([agc, awb, blc, ccm, color_processing, filter, gamma_out, lsc, lux])
> +tuner.add([agc, awb, blc, ccm, color_processing, filter, gamma_out, lsc, lux, wdr])
>  tuner.set_input_parser(YamlParser())
>  tuner.set_output_formatter(YamlOutput())
>  
>  # Bayesian AWB uses the lux value, so insert the lux algorithm before AWB.
>  tuner.set_output_order([agc, lux, awb, blc, ccm, color_processing,
> -                        filter, gamma_out, lsc])
> +                        filter, gamma_out, lsc, wdr])
>  
>  if __name__ == '__main__':
>      sys.exit(tuner.run(sys.argv))
> -- 
> 2.43.0
>

Patch
diff mbox series

diff --git a/utils/tuning/rkisp1.py b/utils/tuning/rkisp1.py
index 207b717a029c..1c9261021922 100755
--- a/utils/tuning/rkisp1.py
+++ b/utils/tuning/rkisp1.py
@@ -47,15 +47,18 @@  lsc = LSCRkISP1(debug=[lt.Debug.Plot],
                 # values.  This can also be a custom function.
                 smoothing_function=lt.smoothing.MedianBlur(3),)
 lux = LuxRkISP1(debug=[lt.Debug.Plot])
+wdr = StaticModule('WideDynamicRange',
+                   { 'ExposureConstraint': { 'MaxBrightPixels': 0.02, 'yTarget': 0.95 },
+                     'MinExposureValue': -4.0 })
 
 tuner = lt.Tuner('RkISP1')
-tuner.add([agc, awb, blc, ccm, color_processing, filter, gamma_out, lsc, lux])
+tuner.add([agc, awb, blc, ccm, color_processing, filter, gamma_out, lsc, lux, wdr])
 tuner.set_input_parser(YamlParser())
 tuner.set_output_formatter(YamlOutput())
 
 # Bayesian AWB uses the lux value, so insert the lux algorithm before AWB.
 tuner.set_output_order([agc, lux, awb, blc, ccm, color_processing,
-                        filter, gamma_out, lsc])
+                        filter, gamma_out, lsc, wdr])
 
 if __name__ == '__main__':
     sys.exit(tuner.run(sys.argv))