[1/2] meson: make the default value of "documentation" feature explicit
diff mbox series

Message ID 20250404161237.1298653-1-foss+libcamera@0leil.net
State New
Headers show
Series
  • [1/2] meson: make the default value of "documentation" feature explicit
Related show

Commit Message

Quentin Schulz April 4, 2025, 4:12 p.m. UTC 
From: Quentin Schulz <quentin.schulz@cherry.de>

The meson documentation on the feature build options isn't clear if a
missing "value" is legal and if it is, what its default value is.[1]

Therefore, let's make it explicit by using what is experimentally the
default: auto.

[1] https://mesonbuild.com/Build-options.html#features

Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de>
---
 meson_options.txt | 1 +
 1 file changed, 1 insertion(+)

Comments

Laurent Pinchart April 4, 2025, 5:07 p.m. UTC | #1 
Hi Quentin,

Thank you for the patch.

On Fri, Apr 04, 2025 at 06:12:34PM +0200, Quentin Schulz wrote:
> From: Quentin Schulz <quentin.schulz@cherry.de>
> 
> The meson documentation on the feature build options isn't clear if a
> missing "value" is legal and if it is, what its default value is.[1]
> 
> Therefore, let's make it explicit by using what is experimentally the
> default: auto.
> 
> [1] https://mesonbuild.com/Build-options.html#features
> 
> Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  meson_options.txt | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/meson_options.txt b/meson_options.txt
> index 1877d800..2104469e 100644
> --- a/meson_options.txt
> +++ b/meson_options.txt
> @@ -18,6 +18,7 @@ option('cam',
>  
>  option('documentation',
>          type : 'feature',
> +        value : 'auto',
>          description : 'Generate the project documentation')
>  
>  option('doc_werror',

Patch
diff mbox series 

diff --git a/meson_options.txt b/meson_options.txt
index 1877d800..2104469e 100644
--- a/meson_options.txt
+++ b/meson_options.txt
@@ -18,6 +18,7 @@  option('cam',
 
 option('documentation',
         type : 'feature',
+        value : 'auto',
         description : 'Generate the project documentation')
 
 option('doc_werror',