| Message ID | 20250331144352.736700-8-stefan.klug@ideasonboard.com |
|---|---|
| State | New |
| Headers | show |
| Series |
|
| Related | show |
Quoting Stefan Klug (2025-03-31 15:43:46) > The 6.13 kernel driver has a bug the the JPEG/sYCC color space is not > applied correctly. Add the color space to the debug log output to be > able to detect that now and later. > > Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com> > --- > src/libcamera/pipeline/rkisp1/rkisp1.cpp | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp > index 132ab40fdbf7..bd74b73d1e68 100644 > --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp > +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp > @@ -891,7 +891,8 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c) > > LOG(RkISP1, Debug) > << "ISP output pad configured with " << format > - << " crop " << outputCrop; > + << " crop " << outputCrop > + << " color space " << ColorSpace::toString(format.colorSpace); Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > > IPACameraSensorInfo sensorInfo; > ret = data->sensor_->sensorInfo(&sensorInfo); > -- > 2.43.0 >
diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp index 132ab40fdbf7..bd74b73d1e68 100644 --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp @@ -891,7 +891,8 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c) LOG(RkISP1, Debug) << "ISP output pad configured with " << format - << " crop " << outputCrop; + << " crop " << outputCrop + << " color space " << ColorSpace::toString(format.colorSpace); IPACameraSensorInfo sensorInfo; ret = data->sensor_->sensorInfo(&sensorInfo);
The 6.13 kernel driver has a bug the the JPEG/sYCC color space is not applied correctly. Add the color space to the debug log output to be able to detect that now and later. Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com> --- src/libcamera/pipeline/rkisp1/rkisp1.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)