| Message ID | 20250326080034.1733385-2-paul.elder@ideasonboard.com |
|---|---|
| State | New |
| Headers | show |
| Series |
|
| Related | show |
Hi Paul, Thank you for the patch. On Wed, Mar 26, 2025 at 05:00:31PM +0900, Paul Elder wrote: > From: Kieran Bingham <kieran.bingham@ideasonboard.com> > > Support the test suite iterating the factories by exposing a const > retriever of the factory name. > > Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > Signed-off-by: Paul Elder <paul.elder@ideasonboard.com> > --- > Changes in v2: > - recover from bitrot > --- > src/ipa/libipa/camera_sensor_helper.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/ipa/libipa/camera_sensor_helper.h b/src/ipa/libipa/camera_sensor_helper.h > index a9300a64f1e7..92f527108137 100644 > --- a/src/ipa/libipa/camera_sensor_helper.h > +++ b/src/ipa/libipa/camera_sensor_helper.h > @@ -60,6 +60,8 @@ public: > > static std::vector<CameraSensorHelperFactoryBase *> &factories(); > > + const std::string &name() const { return name_; }; Drop the final semicolon. Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > + > private: > LIBCAMERA_DISABLE_COPY_AND_MOVE(CameraSensorHelperFactoryBase) >
diff --git a/src/ipa/libipa/camera_sensor_helper.h b/src/ipa/libipa/camera_sensor_helper.h index a9300a64f1e7..92f527108137 100644 --- a/src/ipa/libipa/camera_sensor_helper.h +++ b/src/ipa/libipa/camera_sensor_helper.h @@ -60,6 +60,8 @@ public: static std::vector<CameraSensorHelperFactoryBase *> &factories(); + const std::string &name() const { return name_; }; + private: LIBCAMERA_DISABLE_COPY_AND_MOVE(CameraSensorHelperFactoryBase)