| Message ID | 20250324170803.103296-6-stefan.klug@ideasonboard.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series |
|
| Related | show |
Quoting Stefan Klug (2025-03-24 17:07:40) > Add tests for small inter quantile mean ranges. These cases were > fixed in the last commit. > Excellent, tests to prove the series works :D Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com> > --- > test/ipa/libipa/histogram.cpp | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/test/ipa/libipa/histogram.cpp b/test/ipa/libipa/histogram.cpp > index b96626054af0..b0f9644cebc7 100644 > --- a/test/ipa/libipa/histogram.cpp > +++ b/test/ipa/libipa/histogram.cpp > @@ -55,6 +55,10 @@ protected: > /* Test quantile means that are in the middle of the bins */ > ASSERT_EQ(hist.interQuantileMean(0.25, 0.75), 1.0); > > + /* Test small ranges at the borders of the histogram */ > + ASSERT_EQ(hist.interQuantileMean(0.0, 0.1), 0.1); > + ASSERT_EQ(hist.interQuantileMean(0.9, 1.0), 1.9); > + > return TestPass; > } > }; > -- > 2.43.0 >
Hi Stefan, Thank you for the patch. On Mon, Mar 24, 2025 at 06:07:40PM +0100, Stefan Klug wrote: > Add tests for small inter quantile mean ranges. These cases were > fixed in the last commit. > > Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com> > --- > test/ipa/libipa/histogram.cpp | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/test/ipa/libipa/histogram.cpp b/test/ipa/libipa/histogram.cpp > index b96626054af0..b0f9644cebc7 100644 > --- a/test/ipa/libipa/histogram.cpp > +++ b/test/ipa/libipa/histogram.cpp > @@ -55,6 +55,10 @@ protected: > /* Test quantile means that are in the middle of the bins */ > ASSERT_EQ(hist.interQuantileMean(0.25, 0.75), 1.0); > > + /* Test small ranges at the borders of the histogram */ s/histogram/histogram./ Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > + ASSERT_EQ(hist.interQuantileMean(0.0, 0.1), 0.1); > + ASSERT_EQ(hist.interQuantileMean(0.9, 1.0), 1.9); > + > return TestPass; > } > };
diff --git a/test/ipa/libipa/histogram.cpp b/test/ipa/libipa/histogram.cpp index b96626054af0..b0f9644cebc7 100644 --- a/test/ipa/libipa/histogram.cpp +++ b/test/ipa/libipa/histogram.cpp @@ -55,6 +55,10 @@ protected: /* Test quantile means that are in the middle of the bins */ ASSERT_EQ(hist.interQuantileMean(0.25, 0.75), 1.0); + /* Test small ranges at the borders of the histogram */ + ASSERT_EQ(hist.interQuantileMean(0.0, 0.1), 0.1); + ASSERT_EQ(hist.interQuantileMean(0.9, 1.0), 1.9); + return TestPass; } };
Add tests for small inter quantile mean ranges. These cases were fixed in the last commit. Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com> --- test/ipa/libipa/histogram.cpp | 4 ++++ 1 file changed, 4 insertions(+)