| Message ID | 20250310170303.185199-1-barnabas.pocze@ideasonboard.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series |
|
| Related | show |
Hi Barnabás On Mon, Mar 10, 2025 at 06:03:03PM +0100, Barnabás Pőcze wrote: > Use the proper path to include `libcamera/control_ids.h`. > > Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com> Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com> Thanks j > --- > src/ipa/simple/algorithms/lut.cpp | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/ipa/simple/algorithms/lut.cpp b/src/ipa/simple/algorithms/lut.cpp > index 0ba2391f8..18f3a550b 100644 > --- a/src/ipa/simple/algorithms/lut.cpp > +++ b/src/ipa/simple/algorithms/lut.cpp > @@ -14,9 +14,9 @@ > > #include <libcamera/base/log.h> > > -#include "simple/ipa_context.h" > +#include <libcamera/control_ids.h> > > -#include "control_ids.h" > +#include "simple/ipa_context.h" > > namespace libcamera { > > -- > 2.48.1 >
Quoting Barnabás Pőcze (2025-03-10 17:03:03) > Use the proper path to include `libcamera/control_ids.h`. > > Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com> > --- > src/ipa/simple/algorithms/lut.cpp | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/ipa/simple/algorithms/lut.cpp b/src/ipa/simple/algorithms/lut.cpp > index 0ba2391f8..18f3a550b 100644 > --- a/src/ipa/simple/algorithms/lut.cpp > +++ b/src/ipa/simple/algorithms/lut.cpp > @@ -14,9 +14,9 @@ > > #include <libcamera/base/log.h> > > -#include "simple/ipa_context.h" > +#include <libcamera/control_ids.h> > > -#include "control_ids.h" Eeek - does this already find control_ids.h? That makes me think we have incorrectly added libcamera/ to the default include path somewhere ... I wouldn't expect it to be allowed to compile like that... But that means I believe the patch is correct by itself ! Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > +#include "simple/ipa_context.h" > > namespace libcamera { > > -- > 2.48.1 >
diff --git a/src/ipa/simple/algorithms/lut.cpp b/src/ipa/simple/algorithms/lut.cpp index 0ba2391f8..18f3a550b 100644 --- a/src/ipa/simple/algorithms/lut.cpp +++ b/src/ipa/simple/algorithms/lut.cpp @@ -14,9 +14,9 @@ #include <libcamera/base/log.h> -#include "simple/ipa_context.h" +#include <libcamera/control_ids.h> -#include "control_ids.h" +#include "simple/ipa_context.h" namespace libcamera {
Use the proper path to include `libcamera/control_ids.h`. Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com> --- src/ipa/simple/algorithms/lut.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)