Revert "README.rst: Report py dependencies"
diff mbox series

Message ID 20250304164213.98531-1-jacopo.mondi@ideasonboard.com
State Accepted
Commit 39419ce431dbd4f34d8772bd31bb7f44a3534f86
Headers show
Series
  • Revert "README.rst: Report py dependencies"
Related show

Commit Message

Jacopo Mondi March 4, 2025, 4:42 p.m. UTC
This reverts commit 36753f5cbbcd7c9e00fa3657d918cbe298f48c9c.

Commit 36753f5cbbcd ("README.rst: Report py dependencies")
duplicated the entries for the Python bindings dependencies,
and does not list libpython3-dev which is still a requirement.

Revert it.

Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
---
 README.rst | 3 ---
 1 file changed, 3 deletions(-)

Comments

Laurent Pinchart March 4, 2025, 4:54 p.m. UTC | #1
On Tue, Mar 04, 2025 at 05:42:12PM +0100, Jacopo Mondi wrote:
> This reverts commit 36753f5cbbcd7c9e00fa3657d918cbe298f48c9c.
> 
> Commit 36753f5cbbcd ("README.rst: Report py dependencies")
> duplicated the entries for the Python bindings dependencies,
> and does not list libpython3-dev which is still a requirement.
> 
> Revert it.
> 
> Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  README.rst | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/README.rst b/README.rst
> index 4068c6cc83ca..ae5126e25542 100644
> --- a/README.rst
> +++ b/README.rst
> @@ -93,9 +93,6 @@ for tracing with lttng: [optional]
>  for android: [optional]
>          libexif-dev libjpeg-dev
>  
> -for Python bindings: [optional]
> -        pybind11-dev
> -
>  for lc-compliance: [optional]
>          libevent-dev libgtest-dev
>
Kieran Bingham March 4, 2025, 7:02 p.m. UTC | #2
Quoting Laurent Pinchart (2025-03-04 16:54:23)
> On Tue, Mar 04, 2025 at 05:42:12PM +0100, Jacopo Mondi wrote:
> > This reverts commit 36753f5cbbcd7c9e00fa3657d918cbe298f48c9c.
> > 
> > Commit 36753f5cbbcd ("README.rst: Report py dependencies")
> > duplicated the entries for the Python bindings dependencies,
> > and does not list libpython3-dev which is still a requirement.
> > 
> > Revert it.
> > 
> > Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> 
> > ---
> >  README.rst | 3 ---
> >  1 file changed, 3 deletions(-)
> > 
> > diff --git a/README.rst b/README.rst
> > index 4068c6cc83ca..ae5126e25542 100644
> > --- a/README.rst
> > +++ b/README.rst
> > @@ -93,9 +93,6 @@ for tracing with lttng: [optional]
> >  for android: [optional]
> >          libexif-dev libjpeg-dev
> >  
> > -for Python bindings: [optional]
> > -        pybind11-dev
> > -
> >  for lc-compliance: [optional]
> >          libevent-dev libgtest-dev
> >  
> 
> -- 
> Regards,
> 
> Laurent Pinchart

Patch
diff mbox series

diff --git a/README.rst b/README.rst
index 4068c6cc83ca..ae5126e25542 100644
--- a/README.rst
+++ b/README.rst
@@ -93,9 +93,6 @@  for tracing with lttng: [optional]
 for android: [optional]
         libexif-dev libjpeg-dev
 
-for Python bindings: [optional]
-        pybind11-dev
-
 for lc-compliance: [optional]
         libevent-dev libgtest-dev