README.rst: Remove duplicate Python entry

22919 diff mbox series

Commit 36753f5cbbcd ("README.rst: Report py dependencies")
dropped the requirement for libpython3-dev but did that by introducing
a duplicated entry for the Python bindings in the dependencies
description.

Fix that by removing the outdated entry.

Fixes: 36753f5cbbcd ("README.rst: Report py dependencies")
Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
---
 README.rst | 3 ---
 1 file changed, 3 deletions(-)

Quoting Jacopo Mondi (2025-03-04 11:02:36)
> Commit 36753f5cbbcd ("README.rst: Report py dependencies")
> dropped the requirement for libpython3-dev but did that by introducing
> a duplicated entry for the Python bindings in the dependencies
> description.
> 
> Fix that by removing the outdated entry.
> 
> Fixes: 36753f5cbbcd ("README.rst: Report py dependencies")
> Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
> ---
>  README.rst | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/README.rst b/README.rst
> index 4068c6cc83ca..d8b6ec2208fb 100644
> --- a/README.rst
> +++ b/README.rst
> @@ -72,9 +72,6 @@ for documentation: [optional]
>  for gstreamer: [optional]
>          libgstreamer1.0-dev libgstreamer-plugins-base1.0-dev
>  
> -for Python bindings: [optional]
> -        libpython3-dev pybind11-dev

I believe both of these are required. It looks like my patch
36753f5cbbcd7c9e00fa3657d918cbe298f48c9c was just plain wrong and
perhaps should just be reverted!

I would very much like to keep libpython3-dev as a dependency as it's
certainly required! ( I discovered that when cross compiling in a
container for RPi - it fails to build the python bindings if you don't
have libpython3-dev! )

--
Kieran

> -
>  for cam: [optional]
>          libevent-dev is required to support cam, however the following
>          optional dependencies bring more functionality to the cam test
> -- 
> 2.48.1
>

Hi Kieran

On Tue, Mar 04, 2025 at 02:38:36PM +0000, Kieran Bingham wrote:
> Quoting Jacopo Mondi (2025-03-04 11:02:36)
> > Commit 36753f5cbbcd ("README.rst: Report py dependencies")
> > dropped the requirement for libpython3-dev but did that by introducing
> > a duplicated entry for the Python bindings in the dependencies
> > description.
> >
> > Fix that by removing the outdated entry.
> >
> > Fixes: 36753f5cbbcd ("README.rst: Report py dependencies")
> > Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
> > ---
> >  README.rst | 3 ---
> >  1 file changed, 3 deletions(-)
> >
> > diff --git a/README.rst b/README.rst
> > index 4068c6cc83ca..d8b6ec2208fb 100644
> > --- a/README.rst
> > +++ b/README.rst
> > @@ -72,9 +72,6 @@ for documentation: [optional]
> >  for gstreamer: [optional]
> >          libgstreamer1.0-dev libgstreamer-plugins-base1.0-dev
> >
> > -for Python bindings: [optional]
> > -        libpython3-dev pybind11-dev
>
> I believe both of these are required. It looks like my patch
> 36753f5cbbcd7c9e00fa3657d918cbe298f48c9c was just plain wrong and
> perhaps should just be reverted!
>
> I would very much like to keep libpython3-dev as a dependency as it's
> certainly required! ( I discovered that when cross compiling in a
> container for RPi - it fails to build the python bindings if you don't
> have libpython3-dev! )

I litterally just hit that.

I'll send a patch to remote the entry added by
36753f5cbbcd7c9e00fa3657d918cbe298f48c9c
>
> --
> Kieran
>
> > -
> >  for cam: [optional]
> >          libevent-dev is required to support cam, however the following
> >          optional dependencies bring more functionality to the cam test
> > --
> > 2.48.1
> >