| Message ID | 20250223230403.1226-13-laurent.pinchart@ideasonboard.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series |
|
| Related | show |
Hi Laurent, Thank you for the patch. On Mon, Feb 24, 2025 at 01:04:00AM +0200, Laurent Pinchart wrote: > Fix the top-level file description to mention the file contains an AWB > grey world implementation, not a base class, and fix a grammar mistake > in a documentation block. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Stefan Klug <stefan.klug@ideasonboard.com> > --- > src/ipa/libipa/awb_grey.cpp | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/src/ipa/libipa/awb_grey.cpp b/src/ipa/libipa/awb_grey.cpp > index 0e6c5220c393..d3d2132b8869 100644 > --- a/src/ipa/libipa/awb_grey.cpp > +++ b/src/ipa/libipa/awb_grey.cpp > @@ -2,7 +2,7 @@ > /* > * Copyright (C) 2024 Ideas on Board Oy > * > - * Base class for grey world AWB algorithm > + * Implementation of grey world AWB algorithm > */ > > #include "awb_grey.h" > @@ -61,10 +61,10 @@ int AwbGrey::init(const YamlObject &tuningData) > * \param[in] stats The statistics to use for the calculation > * \param[in] lux The lux value of the scene > * > - * Estimates the colour temperature based on the colours::estimateCCT function. > - * The gains are calculated purely based on the RGB means provided by the \a > - * stats. The colour temperature is not taken into account when calculating the > - * gains. > + * The colour temperature is estimated based on the colours::estimateCCT() > + * function. The gains are calculated purely based on the RGB means provided by > + * the \a stats. The colour temperature is not taken into account when > + * calculating the gains. > * > * The \a lux parameter is not used in this algorithm. > * > -- > Regards, > > Laurent Pinchart >
diff --git a/src/ipa/libipa/awb_grey.cpp b/src/ipa/libipa/awb_grey.cpp index 0e6c5220c393..d3d2132b8869 100644 --- a/src/ipa/libipa/awb_grey.cpp +++ b/src/ipa/libipa/awb_grey.cpp @@ -2,7 +2,7 @@ /* * Copyright (C) 2024 Ideas on Board Oy * - * Base class for grey world AWB algorithm + * Implementation of grey world AWB algorithm */ #include "awb_grey.h" @@ -61,10 +61,10 @@ int AwbGrey::init(const YamlObject &tuningData) * \param[in] stats The statistics to use for the calculation * \param[in] lux The lux value of the scene * - * Estimates the colour temperature based on the colours::estimateCCT function. - * The gains are calculated purely based on the RGB means provided by the \a - * stats. The colour temperature is not taken into account when calculating the - * gains. + * The colour temperature is estimated based on the colours::estimateCCT() + * function. The gains are calculated purely based on the RGB means provided by + * the \a stats. The colour temperature is not taken into account when + * calculating the gains. * * The \a lux parameter is not used in this algorithm. *
Fix the top-level file description to mention the file contains an AWB grey world implementation, not a base class, and fix a grammar mistake in a documentation block. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- src/ipa/libipa/awb_grey.cpp | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)