[libcamera-devel,v2,8/9] test: object-invoke: Invoke method in blocking mode

Message ID 20191028104913.14985-9-laurent.pinchart@ideasonboard.com
State Accepted
Headers show
Series
  • Add support for blocking method invocation
Related show

Commit Message

Laurent Pinchart Oct. 28, 2019, 10:49 a.m. UTC
From: Jacopo Mondi <jacopo@jmondi.org>

Change the object-invoke test to perform the second method invocation
operation in blocking mode.

Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 test/object-invoke.cpp | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Niklas Söderlund Oct. 29, 2019, 11:30 p.m. UTC | #1
Hi Jacopo,

Thanks for your work.

On 2019-10-28 12:49:12 +0200, Laurent Pinchart wrote:
> From: Jacopo Mondi <jacopo@jmondi.org>
> 
> Change the object-invoke test to perform the second method invocation
> operation in blocking mode.
> 
> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>

> ---
>  test/object-invoke.cpp | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/test/object-invoke.cpp b/test/object-invoke.cpp
> index f6ae2604db76..6582fa75ae11 100644
> --- a/test/object-invoke.cpp
> +++ b/test/object-invoke.cpp
> @@ -5,7 +5,6 @@
>   * object-invoke.cpp - Cross-thread Object method invocation test
>   */
>  
> -#include <chrono>
>  #include <iostream>
>  #include <thread>
>  
> @@ -103,8 +102,7 @@ protected:
>  		thread_.start();
>  
>  		object.invokeMethod(&InvokedObject::method,
> -				    ConnectionTypeAuto, 42);
> -		this_thread::sleep_for(chrono::milliseconds(100));
> +				    ConnectionTypeBlocking, 42);
>  
>  		switch (object.status()) {
>  		case InvokedObject::NoCall:
> -- 
> Regards,
> 
> Laurent Pinchart
> 
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel@lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel

Patch

diff --git a/test/object-invoke.cpp b/test/object-invoke.cpp
index f6ae2604db76..6582fa75ae11 100644
--- a/test/object-invoke.cpp
+++ b/test/object-invoke.cpp
@@ -5,7 +5,6 @@ 
  * object-invoke.cpp - Cross-thread Object method invocation test
  */
 
-#include <chrono>
 #include <iostream>
 #include <thread>
 
@@ -103,8 +102,7 @@  protected:
 		thread_.start();
 
 		object.invokeMethod(&InvokedObject::method,
-				    ConnectionTypeAuto, 42);
-		this_thread::sleep_for(chrono::milliseconds(100));
+				    ConnectionTypeBlocking, 42);
 
 		switch (object.status()) {
 		case InvokedObject::NoCall: