| Message ID | 20250203104318.135628-2-pobrn@protonmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series |
|
| Related | show |
Quoting Barnabás Pőcze (2025-02-03 10:43:24) > Just return an `std::unique_ptr` constructed from an empty > initializer instead of doing a `reset()` on the existing > `config` variable and returning that. This is simpler. > > Signed-off-by: Barnabás Pőcze <pobrn@protonmail.com> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > --- > src/libcamera/pipeline/virtual/virtual.cpp | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/src/libcamera/pipeline/virtual/virtual.cpp b/src/libcamera/pipeline/virtual/virtual.cpp > index fc46653f6..94c2bd91e 100644 > --- a/src/libcamera/pipeline/virtual/virtual.cpp > +++ b/src/libcamera/pipeline/virtual/virtual.cpp > @@ -232,8 +232,7 @@ PipelineHandlerVirtual::generateConfiguration(Camera *camera, > default: > LOG(Virtual, Error) > << "Requested stream role not supported: " << role; > - config.reset(); > - return config; > + return {}; > } > > std::map<PixelFormat, std::vector<SizeRange>> streamFormats; > -- > 2.48.1 > >
Hi Barnabás On Mon, Feb 03, 2025 at 10:43:24AM +0000, Barnabás Pőcze wrote: > Just return an `std::unique_ptr` constructed from an empty > initializer instead of doing a `reset()` on the existing > `config` variable and returning that. This is simpler. > > Signed-off-by: Barnabás Pőcze <pobrn@protonmail.com> Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com> Thanks j > --- > src/libcamera/pipeline/virtual/virtual.cpp | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/src/libcamera/pipeline/virtual/virtual.cpp b/src/libcamera/pipeline/virtual/virtual.cpp > index fc46653f6..94c2bd91e 100644 > --- a/src/libcamera/pipeline/virtual/virtual.cpp > +++ b/src/libcamera/pipeline/virtual/virtual.cpp > @@ -232,8 +232,7 @@ PipelineHandlerVirtual::generateConfiguration(Camera *camera, > default: > LOG(Virtual, Error) > << "Requested stream role not supported: " << role; > - config.reset(); > - return config; > + return {}; > } > > std::map<PixelFormat, std::vector<SizeRange>> streamFormats; > -- > 2.48.1 > >
diff --git a/src/libcamera/pipeline/virtual/virtual.cpp b/src/libcamera/pipeline/virtual/virtual.cpp index fc46653f6..94c2bd91e 100644 --- a/src/libcamera/pipeline/virtual/virtual.cpp +++ b/src/libcamera/pipeline/virtual/virtual.cpp @@ -232,8 +232,7 @@ PipelineHandlerVirtual::generateConfiguration(Camera *camera, default: LOG(Virtual, Error) << "Requested stream role not supported: " << role; - config.reset(); - return config; + return {}; } std::map<PixelFormat, std::vector<SizeRange>> streamFormats;
Just return an `std::unique_ptr` constructed from an empty initializer instead of doing a `reset()` on the existing `config` variable and returning that. This is simpler. Signed-off-by: Barnabás Pőcze <pobrn@protonmail.com> --- src/libcamera/pipeline/virtual/virtual.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)