Message ID | 20250130115001.1129305-22-pobrn@protonmail.com |
---|---|
State | New |
Headers | show |
Series |
|
Related | show |
Hi Barnabás On Thu, Jan 30, 2025 at 11:51:50AM +0000, Barnabás Pőcze wrote: > Rename the test to `StopWithRequestsQueued` for more clarity. > > Suggested-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com> > Signed-off-by: Barnabás Pőcze <pobrn@protonmail.com> Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com> Thanks j > --- > src/apps/lc-compliance/tests/capture_test.cpp | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/apps/lc-compliance/tests/capture_test.cpp b/src/apps/lc-compliance/tests/capture_test.cpp > index db1d52fc9..39761f9b1 100644 > --- a/src/apps/lc-compliance/tests/capture_test.cpp > +++ b/src/apps/lc-compliance/tests/capture_test.cpp > @@ -104,13 +104,13 @@ TEST_P(SimpleCapture, CaptureStartStop) > } > > /* > - * Test unbalanced stop > + * Test stop with queued requests > * > * Makes sure the camera supports a stop with requests queued. Example failure > * is a camera that does not handle cancelation of buffers coming back from the > * video device while stopping. > */ > -TEST_P(SimpleCapture, UnbalancedStop) > +TEST_P(SimpleCapture, StopWithRequestsQueued) > { > const auto &[roles, numRequests] = GetParam(); > > -- > 2.48.1 > >
diff --git a/src/apps/lc-compliance/tests/capture_test.cpp b/src/apps/lc-compliance/tests/capture_test.cpp index db1d52fc9..39761f9b1 100644 --- a/src/apps/lc-compliance/tests/capture_test.cpp +++ b/src/apps/lc-compliance/tests/capture_test.cpp @@ -104,13 +104,13 @@ TEST_P(SimpleCapture, CaptureStartStop) } /* - * Test unbalanced stop + * Test stop with queued requests * * Makes sure the camera supports a stop with requests queued. Example failure * is a camera that does not handle cancelation of buffers coming back from the * video device while stopping. */ -TEST_P(SimpleCapture, UnbalancedStop) +TEST_P(SimpleCapture, StopWithRequestsQueued) { const auto &[roles, numRequests] = GetParam();
Rename the test to `StopWithRequestsQueued` for more clarity. Suggested-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com> Signed-off-by: Barnabás Pőcze <pobrn@protonmail.com> --- src/apps/lc-compliance/tests/capture_test.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)