[v9,11/12] ipa: rkisp1: agc: Report new AeEnable control as available
diff mbox series

Message ID 20250120204515.24096-12-laurent.pinchart@ideasonboard.com
State Accepted
Commit 338ba00e7abfe8edfa169b6cb528c147185fac37
Headers show
Series
  • AEGC controls
Related show

Commit Message

Laurent Pinchart Jan. 20, 2025, 8:45 p.m. UTC 
From: Paul Elder <paul.elder@ideasonboard.com>

Even though the new AeEnable control internally switches on and off the
sub-controls (ExposureTimeMode and AnalogueGainMode), it still needs to
be declared as available. Report this control as available in the
rkisp1 IPA.

Support for the control does not need to be added as it is handled by
the Camera class. It does not need to be handled in metadata either as
the new version of AeEnable is not returned in metadata.

Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Stefan Klug <stefan.klug@ideasonboard.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 src/ipa/rkisp1/algorithms/agc.cpp | 2 ++
 1 file changed, 2 insertions(+)

Patch
diff mbox series 

diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp
index 78122a1f05f8..1680669c6875 100644
--- a/src/ipa/rkisp1/algorithms/agc.cpp
+++ b/src/ipa/rkisp1/algorithms/agc.cpp
@@ -156,6 +156,8 @@  int Agc::init(IPAContext &context, const YamlObject &tuningData)
 		ControlInfo(static_cast<int32_t>(controls::AnalogueGainModeAuto),
 			    static_cast<int32_t>(controls::AnalogueGainModeManual),
 			    static_cast<int32_t>(controls::AnalogueGainModeAuto));
+	/* \todo Move this to the Camera class */
+	context.ctrlMap[&controls::AeEnable] = ControlInfo(false, true, true);
 	context.ctrlMap.merge(controls());
 
 	return 0;