| Message ID | 20250113135108.13924-8-mzamazal@redhat.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series |
|
| Related | show |
Hi Milan, Thank you for the patch. On Mon, Jan 13, 2025 at 02:51:04PM +0100, Milan Zamazal wrote: > For performance reasons, color correction matrix (CCM) is not applied by > default in software ISP. But let's add a commented out example how to > define it to the default tuning file. > > Signed-off-by: Milan Zamazal <mzamazal@redhat.com> > Acked-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > --- > src/ipa/simple/data/uncalibrated.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/src/ipa/simple/data/uncalibrated.yaml b/src/ipa/simple/data/uncalibrated.yaml > index 3f147112..8df3cd4e 100644 > --- a/src/ipa/simple/data/uncalibrated.yaml > +++ b/src/ipa/simple/data/uncalibrated.yaml > @@ -5,6 +5,13 @@ version: 1 > algorithms: > - BlackLevel: > - Awb: > + # Color correction matrices can be defined here: You could explain why this is commented out: # Color correction matrices can be defined here. The CCM algorithm has a # significant performance impact, and should only be enabled if tuned. Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > + # - Ccm: > + # ccms: > + # - ct: 6500 > + # ccm: [ 1, 0, 0, > + # 0, 1, 0, > + # 0, 0, 1] > - Lut: > - Agc: > ...
diff --git a/src/ipa/simple/data/uncalibrated.yaml b/src/ipa/simple/data/uncalibrated.yaml index 3f147112..8df3cd4e 100644 --- a/src/ipa/simple/data/uncalibrated.yaml +++ b/src/ipa/simple/data/uncalibrated.yaml @@ -5,6 +5,13 @@ version: 1 algorithms: - BlackLevel: - Awb: + # Color correction matrices can be defined here: + # - Ccm: + # ccms: + # - ct: 6500 + # ccm: [ 1, 0, 0, + # 0, 1, 0, + # 0, 0, 1] - Lut: - Agc: ...