[v4,3/9] libcamera: software_isp: lut: Remove maybe_unused on a used argument
diff mbox series

Message ID 20250113135108.13924-4-mzamazal@redhat.com
State Superseded
Headers show
Series
  • Software ISP support for CCM
Related show

Commit Message

Milan Zamazal Jan. 13, 2025, 1:51 p.m. UTC 
`params' argument of Lut::prepare is actually used, let's remove
maybe_unused from it.

Signed-off-by: Milan Zamazal <mzamazal@redhat.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
---
 src/ipa/simple/algorithms/lut.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Laurent Pinchart Jan. 26, 2025, 11:04 p.m. UTC | #1 
Hi Milan,

Thank you for the patch.

On Mon, Jan 13, 2025 at 02:51:00PM +0100, Milan Zamazal wrote:
> `params' argument of Lut::prepare is actually used, let's remove
> maybe_unused from it.
> 
> Signed-off-by: Milan Zamazal <mzamazal@redhat.com>
> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  src/ipa/simple/algorithms/lut.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/ipa/simple/algorithms/lut.cpp b/src/ipa/simple/algorithms/lut.cpp
> index d75ff710..243f0818 100644
> --- a/src/ipa/simple/algorithms/lut.cpp
> +++ b/src/ipa/simple/algorithms/lut.cpp
> @@ -83,7 +83,7 @@ void Lut::updateGammaTable(IPAContext &context)
>  void Lut::prepare(IPAContext &context,
>  		  [[maybe_unused]] const uint32_t frame,
>  		  [[maybe_unused]] IPAFrameContext &frameContext,
> -		  [[maybe_unused]] DebayerParams *params)
> +		  DebayerParams *params)
>  {
>  	/*
>  	 * Update the gamma table if needed. This means if black level changes

Patch
diff mbox series 

diff --git a/src/ipa/simple/algorithms/lut.cpp b/src/ipa/simple/algorithms/lut.cpp
index d75ff710..243f0818 100644
--- a/src/ipa/simple/algorithms/lut.cpp
+++ b/src/ipa/simple/algorithms/lut.cpp
@@ -83,7 +83,7 @@  void Lut::updateGammaTable(IPAContext &context)
 void Lut::prepare(IPAContext &context,
 		  [[maybe_unused]] const uint32_t frame,
 		  [[maybe_unused]] IPAFrameContext &frameContext,
-		  [[maybe_unused]] DebayerParams *params)
+		  DebayerParams *params)
 {
 	/*
 	 * Update the gamma table if needed. This means if black level changes