[v7,08/12] controls: Remove AeLocked
diff mbox series

Message ID 20250110235737.1524733-9-paul.elder@ideasonboard.com
State Superseded
Headers show
Series
  • AEGC controls
Related show

Commit Message

Paul Elder Jan. 10, 2025, 11:57 p.m. UTC 
From: Jacopo Mondi <jacopo@jmondi.org>

Now that the codebase has been ported to use the new AEGC controls
remove the definition of AeLocked. AeEnable is not be removed as it will
be redefined.

Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>
Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

---
No change in v7

Changes in v6:
- remove only AeLocked, as AeEnable will be redefined instead of removed
  - (used to be "controls: Remove AeEnable and AeLocked")

No change in v5

No change in v4

No change in v3
---
 src/libcamera/control_ids_core.yaml | 12 ------------
 1 file changed, 12 deletions(-)

Comments

Stefan Klug Jan. 13, 2025, 10:45 a.m. UTC | #1 
Hi Jacopo, hi Paul,

Thank you for the patch. 

On Fri, Jan 10, 2025 at 05:57:33PM -0600, Paul Elder wrote:
> From: Jacopo Mondi <jacopo@jmondi.org>
> 
> Now that the codebase has been ported to use the new AEGC controls
> remove the definition of AeLocked. AeEnable is not be removed as it will
> be redefined.
> 
> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
> Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>
> Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Reviewed-by: Stefan Klug <stefan.klug@ideasonboard.com> 

Cheers,
Stefan

> 
> ---
> No change in v7
> 
> Changes in v6:
> - remove only AeLocked, as AeEnable will be redefined instead of removed
>   - (used to be "controls: Remove AeEnable and AeLocked")
> 
> No change in v5
> 
> No change in v4
> 
> No change in v3
> ---
>  src/libcamera/control_ids_core.yaml | 12 ------------
>  1 file changed, 12 deletions(-)
> 
> diff --git a/src/libcamera/control_ids_core.yaml b/src/libcamera/control_ids_core.yaml
> index 553095481..d88c1852e 100644
> --- a/src/libcamera/control_ids_core.yaml
> +++ b/src/libcamera/control_ids_core.yaml
> @@ -16,18 +16,6 @@ controls:
>  
>          \sa ExposureTime AnalogueGain
>  
> -  - AeLocked:
> -      type: bool
> -      direction: out
> -      description: |
> -        Report the lock status of a running AE algorithm.
> -
> -        If the AE algorithm is locked the value shall be set to true, if it's
> -        converging it shall be set to false. If the AE algorithm is not
> -        running the control shall not be present in the metadata control list.
> -
> -        \sa AeEnable
> -
>    - AeState:
>        type: int32_t
>        direction: out
> -- 
> 2.39.2
>

Patch
diff mbox series 

diff --git a/src/libcamera/control_ids_core.yaml b/src/libcamera/control_ids_core.yaml
index 553095481..d88c1852e 100644
--- a/src/libcamera/control_ids_core.yaml
+++ b/src/libcamera/control_ids_core.yaml
@@ -16,18 +16,6 @@  controls:
 
         \sa ExposureTime AnalogueGain
 
-  - AeLocked:
-      type: bool
-      direction: out
-      description: |
-        Report the lock status of a running AE algorithm.
-
-        If the AE algorithm is locked the value shall be set to true, if it's
-        converging it shall be set to false. If the AE algorithm is not
-        running the control shall not be present in the metadata control list.
-
-        \sa AeEnable
-
   - AeState:
       type: int32_t
       direction: out