[v7,04/12] test: ipa_data_serialization: Use DebugMetadataEnable
diff mbox series

Message ID 20250110235737.1524733-5-paul.elder@ideasonboard.com
State Superseded
Headers show
Series
  • AEGC controls
Related show

Commit Message

Paul Elder Jan. 10, 2025, 11:57 p.m. UTC 
From: Jacopo Mondi <jacopo@jmondi.org>

Replace the deprecated AeEnable control with DebugMetadataEnable
in ipa_data_serialization test. We use DebugMetadataEnable instead of
one of the controls replacing AeEnable as they are not boolean controls.

Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>
Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

---
No change in v7

No change in v6

No change in v5

Changes in v4:
- s/ExposureTimeMode/DebugMetadataEnable/

No change in v3
---
 test/serialization/ipa_data_serializer_test.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stefan Klug Jan. 13, 2025, 10:24 a.m. UTC | #1 
Hi Jacopo,

Thank you for the patch. 

On Fri, Jan 10, 2025 at 05:57:29PM -0600, Paul Elder wrote:
> From: Jacopo Mondi <jacopo@jmondi.org>
> 
> Replace the deprecated AeEnable control with DebugMetadataEnable
> in ipa_data_serialization test. We use DebugMetadataEnable instead of
> one of the controls replacing AeEnable as they are not boolean controls.
> 
> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
> Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>
> Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Reviewed-by: Stefan Klug <stefan.klug@ideasonboard.com> 

Cheers,
Stefan

> 
> ---
> No change in v7
> 
> No change in v6
> 
> No change in v5
> 
> Changes in v4:
> - s/ExposureTimeMode/DebugMetadataEnable/
> 
> No change in v3
> ---
>  test/serialization/ipa_data_serializer_test.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/test/serialization/ipa_data_serializer_test.cpp b/test/serialization/ipa_data_serializer_test.cpp
> index aea63c731..afea93a6c 100644
> --- a/test/serialization/ipa_data_serializer_test.cpp
> +++ b/test/serialization/ipa_data_serializer_test.cpp
> @@ -29,7 +29,7 @@ using namespace std;
>  using namespace libcamera;
>  
>  static const ControlInfoMap Controls = ControlInfoMap({
> -		{ &controls::AeEnable, ControlInfo(false, true) },
> +		{ &controls::DebugMetadataEnable, ControlInfo(false, true) },
>  		{ &controls::ExposureTime, ControlInfo(0, 999999) },
>  		{ &controls::AnalogueGain, ControlInfo(1.0f, 32.0f) },
>  		{ &controls::ColourGains, ControlInfo(0.0f, 32.0f) },
> -- 
> 2.39.2
>

Patch
diff mbox series 

diff --git a/test/serialization/ipa_data_serializer_test.cpp b/test/serialization/ipa_data_serializer_test.cpp
index aea63c731..afea93a6c 100644
--- a/test/serialization/ipa_data_serializer_test.cpp
+++ b/test/serialization/ipa_data_serializer_test.cpp
@@ -29,7 +29,7 @@  using namespace std;
 using namespace libcamera;
 
 static const ControlInfoMap Controls = ControlInfoMap({
-		{ &controls::AeEnable, ControlInfo(false, true) },
+		{ &controls::DebugMetadataEnable, ControlInfo(false, true) },
 		{ &controls::ExposureTime, ControlInfo(0, 999999) },
 		{ &controls::AnalogueGain, ControlInfo(1.0f, 32.0f) },
 		{ &controls::ColourGains, ControlInfo(0.0f, 32.0f) },