[RFC,2/7] libcamera: delayed_controls: Increase log level for dummy pushes
diff mbox series

Message ID 20241220162724.756494-3-stefan.klug@ideasonboard.com
State New
Headers show
Series
  • Improve regulation on rkisp1
Related show

Commit Message

Stefan Klug Dec. 20, 2024, 4:26 p.m. UTC
When an automatic no-op is queued a debug message is printed. Change the
debug level to warning, because that situation is actually an indication
of something going seriously out of sync.

Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>
---
 src/libcamera/delayed_controls.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Paul Elder Feb. 20, 2025, 8:47 a.m. UTC | #1
On Fri, Dec 20, 2024 at 05:26:48PM +0100, Stefan Klug wrote:
> When an automatic no-op is queued a debug message is printed. Change the
> debug level to warning, because that situation is actually an indication
> of something going seriously out of sync.
> 
> Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>

Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>

> ---
>  src/libcamera/delayed_controls.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/libcamera/delayed_controls.cpp b/src/libcamera/delayed_controls.cpp
> index 6c82d5058ae8..2f134cbe7fdd 100644
> --- a/src/libcamera/delayed_controls.cpp
> +++ b/src/libcamera/delayed_controls.cpp
> @@ -303,7 +303,7 @@ void DelayedControls::applyControls(uint32_t sequence)
>  	writeCount_ = sequence + 1;
>  
>  	while (writeCount_ > queueCount_) {
> -		LOG(DelayedControls, Debug)
> +		LOG(DelayedControls, Warning)
>  			<< "Queue is empty, auto queue no-op.";
>  		push(queueCount_, {});
>  	}
> -- 
> 2.43.0
>

Patch
diff mbox series

diff --git a/src/libcamera/delayed_controls.cpp b/src/libcamera/delayed_controls.cpp
index 6c82d5058ae8..2f134cbe7fdd 100644
--- a/src/libcamera/delayed_controls.cpp
+++ b/src/libcamera/delayed_controls.cpp
@@ -303,7 +303,7 @@  void DelayedControls::applyControls(uint32_t sequence)
 	writeCount_ = sequence + 1;
 
 	while (writeCount_ > queueCount_) {
-		LOG(DelayedControls, Debug)
+		LOG(DelayedControls, Warning)
 			<< "Queue is empty, auto queue no-op.";
 		push(queueCount_, {});
 	}