utils: gen-debug-controls: Output direction flag
diff mbox series

Message ID 20241220162601.755377-1-stefan.klug@ideasonboard.com
State New
Headers show
Series
  • utils: gen-debug-controls: Output direction flag
Related show

Commit Message

Stefan Klug Dec. 20, 2024, 4:25 p.m. UTC
The yaml definitions for controls now require a direction attribute
which is not auto generated by gen-debug-controls.py. Fix that.

Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>
---
 utils/gen-debug-controls.py | 1 +
 1 file changed, 1 insertion(+)

Comments

Laurent Pinchart Dec. 20, 2024, 6 p.m. UTC | #1
On Fri, Dec 20, 2024 at 05:25:28PM +0100, Stefan Klug wrote:
> The yaml definitions for controls now require a direction attribute
> which is not auto generated by gen-debug-controls.py. Fix that.
> 
> Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  utils/gen-debug-controls.py | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/utils/gen-debug-controls.py b/utils/gen-debug-controls.py
> index 025850731c0b..272597f4874f 100755
> --- a/utils/gen-debug-controls.py
> +++ b/utils/gen-debug-controls.py
> @@ -106,6 +106,7 @@ def main(argv):
>  
>          p = m.file.relative_to(root_dir)
>          desc = {'type': m.type,
> +                'direction': 'out',
>                  'description': f'Debug control {m.name} found in {p}:{m.line}'}
>          if m.size is not None:
>              desc['size'] = m.size
Kieran Bingham Dec. 20, 2024, 6:06 p.m. UTC | #2
Quoting Stefan Klug (2024-12-20 16:25:28)
> The yaml definitions for controls now require a direction attribute
> which is not auto generated by gen-debug-controls.py. Fix that.
> 
> Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>
> ---
>  utils/gen-debug-controls.py | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/utils/gen-debug-controls.py b/utils/gen-debug-controls.py
> index 025850731c0b..272597f4874f 100755
> --- a/utils/gen-debug-controls.py
> +++ b/utils/gen-debug-controls.py
> @@ -106,6 +106,7 @@ def main(argv):
>  
>          p = m.file.relative_to(root_dir)
>          desc = {'type': m.type,
> +                'direction': 'out',


Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

>                  'description': f'Debug control {m.name} found in {p}:{m.line}'}
>          if m.size is not None:
>              desc['size'] = m.size
> -- 
> 2.43.0
>

Patch
diff mbox series

diff --git a/utils/gen-debug-controls.py b/utils/gen-debug-controls.py
index 025850731c0b..272597f4874f 100755
--- a/utils/gen-debug-controls.py
+++ b/utils/gen-debug-controls.py
@@ -106,6 +106,7 @@  def main(argv):
 
         p = m.file.relative_to(root_dir)
         desc = {'type': m.type,
+                'direction': 'out',
                 'description': f'Debug control {m.name} found in {p}:{m.line}'}
         if m.size is not None:
             desc['size'] = m.size