| Message ID | 20241210153440.1007470-8-mzamazal@redhat.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series |
|
| Related | show |
Quoting Milan Zamazal (2024-12-10 15:34:37) > For performance reasons, color correction matrix (CCM) is not applied by > default in software ISP. But let's add a commented out example how to > define it to the default tuning file. > > Signed-off-by: Milan Zamazal <mzamazal@redhat.com> > --- > src/ipa/simple/data/uncalibrated.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/src/ipa/simple/data/uncalibrated.yaml b/src/ipa/simple/data/uncalibrated.yaml > index 3f147112..8df3cd4e 100644 > --- a/src/ipa/simple/data/uncalibrated.yaml > +++ b/src/ipa/simple/data/uncalibrated.yaml > @@ -5,6 +5,13 @@ version: 1 > algorithms: > - BlackLevel: > - Awb: > + # Color correction matrices can be defined here: > + # - Ccm: > + # ccms: > + # - ct: 6500 > + # ccm: [ 1, 0, 0, > + # 0, 1, 0, > + # 0, 0, 1] Can't really 'review' that - it's only adding a comment, but I can say this ;-) Acked-by: Kieran Bingham <kieran.bingham@ideasonboard.com> That said - should the example show multiple ccms ? but that doesn't matter too much - it would be expected to be written by the tuning tool. so maybe this isn't "needed" but I can see a benefit to having it for development purposes for now ? So - I'm not sure if we should apply this patch or not - but it's definitely useful in case someone is trying to play around with ccm for the short term. > - Lut: > - Agc: > ... > -- > 2.44.2 >
Hi Kieran, thank you for review. Kieran Bingham <kieran.bingham@ideasonboard.com> writes: > Quoting Milan Zamazal (2024-12-10 15:34:37) >> For performance reasons, color correction matrix (CCM) is not applied by >> default in software ISP. But let's add a commented out example how to > >> define it to the default tuning file. >> >> Signed-off-by: Milan Zamazal <mzamazal@redhat.com> >> --- >> src/ipa/simple/data/uncalibrated.yaml | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/src/ipa/simple/data/uncalibrated.yaml b/src/ipa/simple/data/uncalibrated.yaml >> index 3f147112..8df3cd4e 100644 >> --- a/src/ipa/simple/data/uncalibrated.yaml >> +++ b/src/ipa/simple/data/uncalibrated.yaml >> @@ -5,6 +5,13 @@ version: 1 >> algorithms: >> - BlackLevel: >> - Awb: >> + # Color correction matrices can be defined here: >> + # - Ccm: >> + # ccms: >> + # - ct: 6500 >> + # ccm: [ 1, 0, 0, >> + # 0, 1, 0, >> + # 0, 0, 1] > > Can't really 'review' that - it's only adding a comment, but I can say > this ;-) > > > Acked-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > > That said - should the example show multiple ccms ? but that doesn't > matter too much - it would be expected to be written by the tuning tool. > > so maybe this isn't "needed" but I can see a benefit to having it for > development purposes for now ? The purpose is to provide an easy to use example how to define the CCMs for those who'd like to experiment with them. Simply uncomment it and you can see what happens when CCM is enabled. And then the values can be changed to see the corresponding effects. > So - I'm not sure if we should apply this patch or not - but it's > definitely useful in case someone is trying to play around with ccm for > the short term. > > >> - Lut: >> - Agc: >> ... >> -- >> 2.44.2 >>
diff --git a/src/ipa/simple/data/uncalibrated.yaml b/src/ipa/simple/data/uncalibrated.yaml index 3f147112..8df3cd4e 100644 --- a/src/ipa/simple/data/uncalibrated.yaml +++ b/src/ipa/simple/data/uncalibrated.yaml @@ -5,6 +5,13 @@ version: 1 algorithms: - BlackLevel: - Awb: + # Color correction matrices can be defined here: + # - Ccm: + # ccms: + # - ct: 6500 + # ccm: [ 1, 0, 0, + # 0, 1, 0, + # 0, 0, 1] - Lut: - Agc: ...
For performance reasons, color correction matrix (CCM) is not applied by default in software ISP. But let's add a commented out example how to define it to the default tuning file. Signed-off-by: Milan Zamazal <mzamazal@redhat.com> --- src/ipa/simple/data/uncalibrated.yaml | 7 +++++++ 1 file changed, 7 insertions(+)