[v5,5/8] libtuning: Remove the Cam object from ctt_awb.awb()
diff mbox series

Message ID 20241206145242.827886-6-stefan.klug@ideasonboard.com
State Accepted
Headers show
Series
  • rkisp1: Add manual colour temperature control
Related show

Commit Message

Stefan Klug Dec. 6, 2024, 2:52 p.m. UTC
Replace the Cam object with a list parameter to be able to call the
ctt_awb.awb() function from libtuning code.

Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>
---
 utils/tuning/libtuning/ctt_awb.py | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Laurent Pinchart Dec. 9, 2024, 2:06 a.m. UTC | #1
Hi Stefan,

Thank you for the patch.

On Fri, Dec 06, 2024 at 03:52:25PM +0100, Stefan Klug wrote:
> Replace the Cam object with a list parameter to be able to call the
> ctt_awb.awb() function from libtuning code.
> 
> Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>
> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
> Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  utils/tuning/libtuning/ctt_awb.py | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/utils/tuning/libtuning/ctt_awb.py b/utils/tuning/libtuning/ctt_awb.py
> index 899f204da8cf..5494bdb5c103 100644
> --- a/utils/tuning/libtuning/ctt_awb.py
> +++ b/utils/tuning/libtuning/ctt_awb.py
> @@ -18,8 +18,7 @@ logger = logging.getLogger(__name__)
>  """
>  obtain piecewise linear approximation for colour curve
>  """
> -def awb(Cam, cal_cr_list, cal_cb_list, plot):
> -    imgs = Cam.imgs
> +def awb(imgs, cal_cr_list, cal_cb_list, plot):
>      """
>      condense alsc calibration tables into one dictionary
>      """

Patch
diff mbox series

diff --git a/utils/tuning/libtuning/ctt_awb.py b/utils/tuning/libtuning/ctt_awb.py
index 899f204da8cf..5494bdb5c103 100644
--- a/utils/tuning/libtuning/ctt_awb.py
+++ b/utils/tuning/libtuning/ctt_awb.py
@@ -18,8 +18,7 @@  logger = logging.getLogger(__name__)
 """
 obtain piecewise linear approximation for colour curve
 """
-def awb(Cam, cal_cr_list, cal_cb_list, plot):
-    imgs = Cam.imgs
+def awb(imgs, cal_cr_list, cal_cb_list, plot):
     """
     condense alsc calibration tables into one dictionary
     """