| Message ID | 20241202134032.34205-2-isaac.scott@ideasonboard.com |
|---|---|
| State | New |
| Headers | show |
| Series |
|
| Related | show |
Hi Isaac, Thank you for the patch. On Mon, Dec 02, 2024 at 01:40:32PM +0000, Isaac Scott wrote: > The current README states the meson version required is v0.60 or higher. > When running the build process, libcamera says it requires meson >= > 0.63. Update the README to reflect this. > > Signed-off-by: Isaac Scott <isaac.scott@ideasonboard.com> > --- > README.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/README.rst b/README.rst > index 4068c6cc..f1169059 100644 > --- a/README.rst > +++ b/README.rst > @@ -44,7 +44,7 @@ A C++ toolchain: [required] > Either {g++, clang} > > Meson Build system: [required] > - meson (>= 0.60) ninja-build pkg-config > + meson (>= 0.63) ninja-build pkg-config The source of truth is meson.build. I wonder if we should drop the version number here to avoid risks of future discrepancies. > > for the libcamera core: [required] > libyaml-dev python3-yaml python3-ply python3-jinja2
Quoting Laurent Pinchart (2024-12-02 14:13:42) > Hi Isaac, > > Thank you for the patch. > > On Mon, Dec 02, 2024 at 01:40:32PM +0000, Isaac Scott wrote: > > The current README states the meson version required is v0.60 or higher. > > When running the build process, libcamera says it requires meson >= > > 0.63. Update the README to reflect this. > > > > Signed-off-by: Isaac Scott <isaac.scott@ideasonboard.com> > > --- > > README.rst | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/README.rst b/README.rst > > index 4068c6cc..f1169059 100644 > > --- a/README.rst > > +++ b/README.rst > > @@ -44,7 +44,7 @@ A C++ toolchain: [required] > > Either {g++, clang} > > > > Meson Build system: [required] > > - meson (>= 0.60) ninja-build pkg-config > > + meson (>= 0.63) ninja-build pkg-config > > The source of truth is meson.build. I wonder if we should drop the > version number here to avoid risks of future discrepancies. Earlier on in the project we changed this quite a lot - so I suspect it was helpful to say what version we needed, particularly as meson hadn't had a major release back then. But now - indeed - I think we could drop this. Isaac, could you respin this patch and smiply remove the specification here please? -- Kieran > > > > > for the libcamera core: [required] > > libyaml-dev python3-yaml python3-ply python3-jinja2 > > -- > Regards, > > Laurent Pinchart
diff --git a/README.rst b/README.rst index 4068c6cc..f1169059 100644 --- a/README.rst +++ b/README.rst @@ -44,7 +44,7 @@ A C++ toolchain: [required] Either {g++, clang} Meson Build system: [required] - meson (>= 0.60) ninja-build pkg-config + meson (>= 0.63) ninja-build pkg-config for the libcamera core: [required] libyaml-dev python3-yaml python3-ply python3-jinja2
The current README states the meson version required is v0.60 or higher. When running the build process, libcamera says it requires meson >= 0.63. Update the README to reflect this. Signed-off-by: Isaac Scott <isaac.scott@ideasonboard.com> --- README.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)