| Message ID | 20241127133233.247977-2-dan.scally@ideasonboard.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series |
|
| Related | show |
Quoting Daniel Scally (2024-11-27 13:32:32) > Add entries for the OmniVision OV7251 and OV9281 sensors. The control > delay values are drawn from the Raspberry Pi CameraSensorHelper class > for these sensors - the pixel sizes from the datasheets. Both sensors > are monochrome and do not have test pattern settings that correspond > to defined control values. > > Signed-off-by: Daniel Scally <dan.scally@ideasonboard.com> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > --- > .../sensor/camera_sensor_properties.cpp | 20 +++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/src/libcamera/sensor/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp > index 3fe18c16..0eccc937 100644 > --- a/src/libcamera/sensor/camera_sensor_properties.cpp > +++ b/src/libcamera/sensor/camera_sensor_properties.cpp > @@ -360,6 +360,16 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen > .hblankDelay = 2 > }, > } }, > + { "ov7251", { > + .unitCellSize = { 3000, 3000 }, > + .testPatternModes = { }, > + .sensorDelays = { > + .exposureDelay = 2, > + .gainDelay = 2, > + .vblankDelay = 2, > + .hblankDelay = 2 > + }, > + } }, > { "ov8858", { > .unitCellSize = { 1120, 1120 }, > .testPatternModes = { > @@ -389,6 +399,16 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen > }, > .sensorDelays = { }, > } }, > + { "ov9281", { > + .unitCellSize = { 3000, 3000 }, > + .testPatternModes = { }, > + .sensorDelays = { > + .exposureDelay = 2, > + .gainDelay = 2, > + .vblankDelay = 2, > + .hblankDelay = 2 > + }, > + } }, > { "ov13858", { > .unitCellSize = { 1120, 1120 }, > .testPatternModes = { > -- > 2.34.1 >
On Wed, Nov 27, 2024 at 01:32:32PM +0000, Daniel Scally wrote: > Add entries for the OmniVision OV7251 and OV9281 sensors. The control > delay values are drawn from the Raspberry Pi CameraSensorHelper class > for these sensors - the pixel sizes from the datasheets. Both sensors > are monochrome and do not have test pattern settings that correspond > to defined control values. > > Signed-off-by: Daniel Scally <dan.scally@ideasonboard.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > .../sensor/camera_sensor_properties.cpp | 20 +++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/src/libcamera/sensor/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp > index 3fe18c16..0eccc937 100644 > --- a/src/libcamera/sensor/camera_sensor_properties.cpp > +++ b/src/libcamera/sensor/camera_sensor_properties.cpp > @@ -360,6 +360,16 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen > .hblankDelay = 2 > }, > } }, > + { "ov7251", { > + .unitCellSize = { 3000, 3000 }, > + .testPatternModes = { }, > + .sensorDelays = { > + .exposureDelay = 2, > + .gainDelay = 2, > + .vblankDelay = 2, > + .hblankDelay = 2 > + }, > + } }, > { "ov8858", { > .unitCellSize = { 1120, 1120 }, > .testPatternModes = { > @@ -389,6 +399,16 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen > }, > .sensorDelays = { }, > } }, > + { "ov9281", { > + .unitCellSize = { 3000, 3000 }, > + .testPatternModes = { }, > + .sensorDelays = { > + .exposureDelay = 2, > + .gainDelay = 2, > + .vblankDelay = 2, > + .hblankDelay = 2 > + }, > + } }, > { "ov13858", { > .unitCellSize = { 1120, 1120 }, > .testPatternModes = {
diff --git a/src/libcamera/sensor/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp index 3fe18c16..0eccc937 100644 --- a/src/libcamera/sensor/camera_sensor_properties.cpp +++ b/src/libcamera/sensor/camera_sensor_properties.cpp @@ -360,6 +360,16 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen .hblankDelay = 2 }, } }, + { "ov7251", { + .unitCellSize = { 3000, 3000 }, + .testPatternModes = { }, + .sensorDelays = { + .exposureDelay = 2, + .gainDelay = 2, + .vblankDelay = 2, + .hblankDelay = 2 + }, + } }, { "ov8858", { .unitCellSize = { 1120, 1120 }, .testPatternModes = { @@ -389,6 +399,16 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen }, .sensorDelays = { }, } }, + { "ov9281", { + .unitCellSize = { 3000, 3000 }, + .testPatternModes = { }, + .sensorDelays = { + .exposureDelay = 2, + .gainDelay = 2, + .vblankDelay = 2, + .hblankDelay = 2 + }, + } }, { "ov13858", { .unitCellSize = { 1120, 1120 }, .testPatternModes = {
Add entries for the OmniVision OV7251 and OV9281 sensors. The control delay values are drawn from the Raspberry Pi CameraSensorHelper class for these sensors - the pixel sizes from the datasheets. Both sensors are monochrome and do not have test pattern settings that correspond to defined control values. Signed-off-by: Daniel Scally <dan.scally@ideasonboard.com> --- .../sensor/camera_sensor_properties.cpp | 20 +++++++++++++++++++ 1 file changed, 20 insertions(+)