[libcamera-devel] libcamera: controls: Remove rogue ';'

Message ID 20191022133551.17763-1-jacopo@jmondi.org
State Accepted
Commit 408c98ea456a63e3820fe264039a0ff240984372
Headers show
Series
  • [libcamera-devel] libcamera: controls: Remove rogue ';'
Related show

Commit Message

Jacopo Mondi Oct. 22, 2019, 1:35 p.m. UTC
The ';' at the end of an inline method declaration is not required.

Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
---
 include/libcamera/controls.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Laurent Pinchart Oct. 22, 2019, 1:55 p.m. UTC | #1
Hi Jacopo,

Thank you for the patch.

On Tue, Oct 22, 2019 at 03:35:51PM +0200, Jacopo Mondi wrote:
> The ';' at the end of an inline method declaration is not required.
> 
> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  include/libcamera/controls.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h
> index 0d279d508dcc..42e6df7e613d 100644
> --- a/include/libcamera/controls.h
> +++ b/include/libcamera/controls.h
> @@ -30,8 +30,8 @@ public:
>  	ControlValue(int32_t value);
>  	ControlValue(int64_t value);
>  
> -	ControlType type() const { return type_; };
> -	bool isNone() const { return type_ == ControlTypeNone; };
> +	ControlType type() const { return type_; }
> +	bool isNone() const { return type_ == ControlTypeNone; }
>  
>  	template<typename T>
>  	const T &get() const;

Patch

diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h
index 0d279d508dcc..42e6df7e613d 100644
--- a/include/libcamera/controls.h
+++ b/include/libcamera/controls.h
@@ -30,8 +30,8 @@  public:
 	ControlValue(int32_t value);
 	ControlValue(int64_t value);
 
-	ControlType type() const { return type_; };
-	bool isNone() const { return type_ == ControlTypeNone; };
+	ControlType type() const { return type_; }
+	bool isNone() const { return type_ == ControlTypeNone; }
 
 	template<typename T>
 	const T &get() const;