[v4,03/17] ipa: libipa: vector: Add scalar constructor
diff mbox series

Message ID 20241119121928.30939-4-laurent.pinchart@ideasonboard.com
State New
Headers show
Series
  • Improve linear algebra helpers in libipa
Related show

Commit Message

Laurent Pinchart Nov. 19, 2024, 12:19 p.m. UTC
The default constructor leaves the vector data uninitialized. Add a
constructor to fill the vector with copies of a scalar value, and fix
the documentation of the default constructor.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
Changes since v3:

- Make the constructor explicit
---
 src/ipa/libipa/vector.cpp | 8 +++++++-
 src/ipa/libipa/vector.h   | 5 +++++
 2 files changed, 12 insertions(+), 1 deletion(-)

Comments

Milan Zamazal Nov. 19, 2024, 4:57 p.m. UTC | #1
Laurent Pinchart <laurent.pinchart@ideasonboard.com> writes:

> The default constructor leaves the vector data uninitialized. Add a
> constructor to fill the vector with copies of a scalar value, and fix
> the documentation of the default constructor.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Reviewed-by: Milan Zamazal <mzamazal@redhat.com>

> ---
> Changes since v3:
>
> - Make the constructor explicit
> ---
>  src/ipa/libipa/vector.cpp | 8 +++++++-
>  src/ipa/libipa/vector.h   | 5 +++++
>  2 files changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/src/ipa/libipa/vector.cpp b/src/ipa/libipa/vector.cpp
> index 0f0511da151f..5851b9ae2ed3 100644
> --- a/src/ipa/libipa/vector.cpp
> +++ b/src/ipa/libipa/vector.cpp
> @@ -29,7 +29,13 @@ namespace ipa {
>  
>  /**
>   * \fn Vector::Vector()
> - * \brief Construct a zero vector
> + * \brief Construct an uninitialized vector
> + */
> +
> +/**
> + * \fn Vector::Vector(T scalar)
> + * \brief Construct a vector filled with a \a scalar value
> + * \param[in] scalar The scalar value
>   */
>  
>  /**
> diff --git a/src/ipa/libipa/vector.h b/src/ipa/libipa/vector.h
> index 3168835bc13d..5fb7ad7c95dd 100644
> --- a/src/ipa/libipa/vector.h
> +++ b/src/ipa/libipa/vector.h
> @@ -35,6 +35,11 @@ class Vector
>  public:
>  	constexpr Vector() = default;
>  
> +	constexpr explicit Vector(T scalar)
> +	{
> +		data_.fill(scalar);
> +	}
> +
>  	constexpr Vector(const std::array<T, Rows> &data)
>  	{
>  		for (unsigned int i = 0; i < Rows; i++)

Patch
diff mbox series

diff --git a/src/ipa/libipa/vector.cpp b/src/ipa/libipa/vector.cpp
index 0f0511da151f..5851b9ae2ed3 100644
--- a/src/ipa/libipa/vector.cpp
+++ b/src/ipa/libipa/vector.cpp
@@ -29,7 +29,13 @@  namespace ipa {
 
 /**
  * \fn Vector::Vector()
- * \brief Construct a zero vector
+ * \brief Construct an uninitialized vector
+ */
+
+/**
+ * \fn Vector::Vector(T scalar)
+ * \brief Construct a vector filled with a \a scalar value
+ * \param[in] scalar The scalar value
  */
 
 /**
diff --git a/src/ipa/libipa/vector.h b/src/ipa/libipa/vector.h
index 3168835bc13d..5fb7ad7c95dd 100644
--- a/src/ipa/libipa/vector.h
+++ b/src/ipa/libipa/vector.h
@@ -35,6 +35,11 @@  class Vector
 public:
 	constexpr Vector() = default;
 
+	constexpr explicit Vector(T scalar)
+	{
+		data_.fill(scalar);
+	}
+
 	constexpr Vector(const std::array<T, Rows> &data)
 	{
 		for (unsigned int i = 0; i < Rows; i++)