| Message ID | 20241119103740.1919807-8-stefan.klug@ideasonboard.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series |
|
| Related | show |
Hi Stefan, Thank you for the patch. On Tue, Nov 19, 2024 at 11:37:34AM +0100, Stefan Klug wrote: > Use the Matrix class from libcamera/internal in libipa so that the one > from libipa can be dropped later. > > Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com> > --- > src/ipa/libipa/vector.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/ipa/libipa/vector.h b/src/ipa/libipa/vector.h > index 8612a06a2ab2..dcafcb1c0e96 100644 > --- a/src/ipa/libipa/vector.h > +++ b/src/ipa/libipa/vector.h > @@ -14,9 +14,9 @@ > #include <libcamera/base/log.h> > #include <libcamera/base/span.h> > > -#include "libcamera/internal/yaml_parser.h" > +#include "libcamera/internal/matrix.h" > You can drop this blank line. Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > -#include "matrix.h" > +#include "libcamera/internal/yaml_parser.h" > > namespace libcamera { >
diff --git a/src/ipa/libipa/vector.h b/src/ipa/libipa/vector.h index 8612a06a2ab2..dcafcb1c0e96 100644 --- a/src/ipa/libipa/vector.h +++ b/src/ipa/libipa/vector.h @@ -14,9 +14,9 @@ #include <libcamera/base/log.h> #include <libcamera/base/span.h> -#include "libcamera/internal/yaml_parser.h" +#include "libcamera/internal/matrix.h" -#include "matrix.h" +#include "libcamera/internal/yaml_parser.h" namespace libcamera {
Use the Matrix class from libcamera/internal in libipa so that the one from libipa can be dropped later. Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com> --- src/ipa/libipa/vector.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)