[1/2] libcamera: android: include token only in cros_mojo_token.h
diff mbox series

Message ID 20241014140038.1133270-2-chenghaoyang@chromium.org
State New
Headers show
Series
  • Add GyroSensor
Related show

Commit Message

Harvey Yang Oct. 14, 2024, 1:18 p.m. UTC 
To avoid unnecessary dependency, especially on libchrome base, include
only `cros-camera/camera_mojo_channel_manager_token.h` in
`cros_mojo_token.h`.

Signed-off-by: Harvey Yang <chenghaoyang@chromium.org>
Co-developed-by: Han-Lin Chen <hanlinchen@chromium.org>
Signed-off-by: Han-Lin Chen <hanlinchen@chromium.org>
---
 src/android/cros_mojo_token.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Laurent Pinchart Oct. 14, 2024, 7:32 p.m. UTC | #1 
Hi Harvey, Han-Lin,

Thank you for the patch.

On Mon, Oct 14, 2024 at 01:18:56PM +0000, Harvey Yang wrote:
> To avoid unnecessary dependency, especially on libchrome base, include
> only `cros-camera/camera_mojo_channel_manager_token.h` in
> `cros_mojo_token.h`.
> 
> Signed-off-by: Harvey Yang <chenghaoyang@chromium.org>
> Co-developed-by: Han-Lin Chen <hanlinchen@chromium.org>
> Signed-off-by: Han-Lin Chen <hanlinchen@chromium.org>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  src/android/cros_mojo_token.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/android/cros_mojo_token.h b/src/android/cros_mojo_token.h
> index d0baa80fc..fc57205a8 100644
> --- a/src/android/cros_mojo_token.h
> +++ b/src/android/cros_mojo_token.h
> @@ -7,6 +7,6 @@
>  
>  #pragma once
>  
> -#include <cros-camera/cros_camera_hal.h>
> +#include <cros-camera/camera_mojo_channel_manager_token.h>
>  
>  inline cros::CameraMojoChannelManagerToken *gCrosMojoToken = nullptr;

Patch
diff mbox series 

diff --git a/src/android/cros_mojo_token.h b/src/android/cros_mojo_token.h
index d0baa80fc..fc57205a8 100644
--- a/src/android/cros_mojo_token.h
+++ b/src/android/cros_mojo_token.h
@@ -7,6 +7,6 @@ 
 
 #pragma once
 
-#include <cros-camera/cros_camera_hal.h>
+#include <cros-camera/camera_mojo_channel_manager_token.h>
 
 inline cros::CameraMojoChannelManagerToken *gCrosMojoToken = nullptr;