[1/2] libcamera: add OS_CHROMEOS when the android_platform is cros
diff mbox series

Message ID 20241014081738.772258-2-chenghaoyang@chromium.org
State New
Headers show
Series
  • Add CrOS into enum LoggingTarget
Related show

Commit Message

Cheng-Hao Yang Oct. 14, 2024, 8:13 a.m. UTC 
From: Han-Lin Chen <hanlinchen@chromium.org>

Add OS_CHROMEOS when the android_platform is cros.

Signed-off-by: Han-Lin Chen <hanlinchen@chromium.org>
Co-developed-by: Harvey Yang <chenghaoyang@chromium.org>
Signed-off-by: Harvey Yang <chenghaoyang@chromium.org>
---
 meson.build | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Laurent Pinchart Oct. 15, 2024, 10:22 a.m. UTC | #1 
Hi Harvey, Han-Lin,

Thank you for the patch.

On Mon, Oct 14, 2024 at 08:13:54AM +0000, Harvey Yang wrote:
> From: Han-Lin Chen <hanlinchen@chromium.org>
> 
> Add OS_CHROMEOS when the android_platform is cros.
> 
> Signed-off-by: Han-Lin Chen <hanlinchen@chromium.org>
> Co-developed-by: Harvey Yang <chenghaoyang@chromium.org>
> Signed-off-by: Harvey Yang <chenghaoyang@chromium.org>
> ---
>  meson.build | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/meson.build b/meson.build
> index 63e45465d..e28fa8599 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -184,6 +184,10 @@ if cc.has_argument('-Wno-c99-designator')
>      ]
>  endif
>  
> +if get_option('android_platform') == 'cros'
> +    common_arguments += ['-DOS_CHROMEOS']
> +endif

This duplicates a logic that defines the same macro in
src/android/cros/meson.build.

> +
>  c_arguments += common_arguments
>  cpp_arguments += common_arguments
>

Patch
diff mbox series 

diff --git a/meson.build b/meson.build
index 63e45465d..e28fa8599 100644
--- a/meson.build
+++ b/meson.build
@@ -184,6 +184,10 @@  if cc.has_argument('-Wno-c99-designator')
     ]
 endif
 
+if get_option('android_platform') == 'cros'
+    common_arguments += ['-DOS_CHROMEOS']
+endif
+
 c_arguments += common_arguments
 cpp_arguments += common_arguments