| Message ID | 20241011092222.537322-4-umang.jain@ideasonboard.com |
|---|---|
| State | Accepted |
| Commit | 3299f84de7dd2c454342d19e0c4d7db662ead536 |
| Headers | show |
| Series |
|
| Related | show |
Quoting Umang Jain (2024-10-11 10:22:22) > Alphabetical order of Forward declarations should be maintained hence, > 'class V4L2Subdevice' should come after 'class SensorConfiguration'. > Fix it. > > Signed-off-by: Umang Jain <umang.jain@ideasonboard.com> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > --- > src/libcamera/pipeline/rkisp1/rkisp1_path.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/libcamera/pipeline/rkisp1/rkisp1_path.h b/src/libcamera/pipeline/rkisp1/rkisp1_path.h > index 8461071f..45be8476 100644 > --- a/src/libcamera/pipeline/rkisp1/rkisp1_path.h > +++ b/src/libcamera/pipeline/rkisp1/rkisp1_path.h > @@ -26,8 +26,8 @@ namespace libcamera { > > class CameraSensor; > class MediaDevice; > -class V4L2Subdevice; > class SensorConfiguration; > +class V4L2Subdevice; > struct StreamConfiguration; > struct V4L2SubdeviceFormat; > > -- > 2.45.2 >
Hi Umang, On Fri, Oct 11, 2024 at 02:52:22PM +0530, Umang Jain wrote: > Alphabetical order of Forward declarations should be maintained hence, > 'class V4L2Subdevice' should come after 'class SensorConfiguration'. > Fix it. > > Signed-off-by: Umang Jain <umang.jain@ideasonboard.com> Reviewed-by: Stefan Klug <stefan.klug@ideasonboard.com> > --- > src/libcamera/pipeline/rkisp1/rkisp1_path.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/libcamera/pipeline/rkisp1/rkisp1_path.h b/src/libcamera/pipeline/rkisp1/rkisp1_path.h > index 8461071f..45be8476 100644 > --- a/src/libcamera/pipeline/rkisp1/rkisp1_path.h > +++ b/src/libcamera/pipeline/rkisp1/rkisp1_path.h > @@ -26,8 +26,8 @@ namespace libcamera { > > class CameraSensor; > class MediaDevice; > -class V4L2Subdevice; > class SensorConfiguration; > +class V4L2Subdevice; > struct StreamConfiguration; > struct V4L2SubdeviceFormat; > > -- > 2.45.2 >
diff --git a/src/libcamera/pipeline/rkisp1/rkisp1_path.h b/src/libcamera/pipeline/rkisp1/rkisp1_path.h index 8461071f..45be8476 100644 --- a/src/libcamera/pipeline/rkisp1/rkisp1_path.h +++ b/src/libcamera/pipeline/rkisp1/rkisp1_path.h @@ -26,8 +26,8 @@ namespace libcamera { class CameraSensor; class MediaDevice; -class V4L2Subdevice; class SensorConfiguration; +class V4L2Subdevice; struct StreamConfiguration; struct V4L2SubdeviceFormat;
Alphabetical order of Forward declarations should be maintained hence, 'class V4L2Subdevice' should come after 'class SensorConfiguration'. Fix it. Signed-off-by: Umang Jain <umang.jain@ideasonboard.com> --- src/libcamera/pipeline/rkisp1/rkisp1_path.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)