[v8,02/18] libcamera: software_isp: Move BlackLevel to libcamera::ipa::soft
diff mbox series

Message ID 20240927134624.801004-3-mzamazal@redhat.com
State Accepted
Commit 306b0f952fa4191df92770d2b754d594f1cfb0cb
Headers show
Series
  • Software ISP refactoring
Related show

Commit Message

Milan Zamazal Sept. 27, 2024, 1:46 p.m. UTC 
IPA modules use custom namespaces for all their internal components to
avoid namespace clashes. The simple IPA module for the software ISP uses
libcamera::ipa::soft for this purpose. It however defines an internal
class named BlackLevel in the root of the libcamera namespace, making it
prone to clashes. Move it to the ipa::soft namespace along with the rest
of the code.

Signed-off-by: Milan Zamazal <mzamazal@redhat.com>
Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com>
---
 src/ipa/simple/black_level.cpp | 5 +++++
 src/ipa/simple/black_level.h   | 4 ++++
 2 files changed, 9 insertions(+)

Patch
diff mbox series 

diff --git a/src/ipa/simple/black_level.cpp b/src/ipa/simple/black_level.cpp
index cc490eb5c..37e0109ce 100644
--- a/src/ipa/simple/black_level.cpp
+++ b/src/ipa/simple/black_level.cpp
@@ -15,6 +15,8 @@  namespace libcamera {
 
 LOG_DEFINE_CATEGORY(IPASoftBL)
 
+namespace ipa::soft {
+
 /**
  * \class BlackLevel
  * \brief Object providing black point level for software ISP
@@ -85,4 +87,7 @@  void BlackLevel::update(SwIspStats::Histogram &yHistogram)
 		}
 	};
 }
+
+} /* namespace ipa::soft */
+
 } /* namespace libcamera */
diff --git a/src/ipa/simple/black_level.h b/src/ipa/simple/black_level.h
index 5e032f9fb..a04230c9c 100644
--- a/src/ipa/simple/black_level.h
+++ b/src/ipa/simple/black_level.h
@@ -14,6 +14,8 @@ 
 
 namespace libcamera {
 
+namespace ipa::soft {
+
 class BlackLevel
 {
 public:
@@ -26,4 +28,6 @@  private:
 	bool blackLevelSet_;
 };
 
+} /* namespace ipa::soft */
+
 } /* namespace libcamera */