| Message ID | 20240916140241.47845-3-kieran.bingham@ideasonboard.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series |
|
| Related | show |
Hi Kieran, Thank you for the patch. On 16/09/24 7:32 pm, Kieran Bingham wrote: > The delay values should be managed correctly. Not the dealys. > > Correct accordingly, but I also hope we'll resolve this > task soon too. > > Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com> Reviewed-by: Umang Jain <umang.jain@ideasonboard.com> > --- > src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp > index c02c7cf374e9..2fee84e56d4d 100644 > --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp > +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp > @@ -1103,7 +1103,7 @@ int PipelineHandlerRkISP1::createCamera(MediaEntity *sensor) > data->properties_ = data->sensor_->properties(); > > /* > - * \todo Read dealy values from the sensor itself or from a > + * \todo Read delay values from the sensor itself or from a > * a sensor database. For now use generic values taken from > * the Raspberry Pi and listed as generic values. > */
Hi Kieran On Mon, Sep 16, 2024 at 04:02:39PM GMT, Kieran Bingham wrote: > The delay values should be managed correctly. Not the dealys. :) Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com> > > Correct accordingly, but I also hope we'll resolve this > task soon too. > > Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > --- > src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp > index c02c7cf374e9..2fee84e56d4d 100644 > --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp > +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp > @@ -1103,7 +1103,7 @@ int PipelineHandlerRkISP1::createCamera(MediaEntity *sensor) > data->properties_ = data->sensor_->properties(); > > /* > - * \todo Read dealy values from the sensor itself or from a > + * \todo Read delay values from the sensor itself or from a > * a sensor database. For now use generic values taken from > * the Raspberry Pi and listed as generic values. > */ > -- > 2.46.0 >
On Mon, Sep 16, 2024 at 04:02:39PM GMT, Kieran Bingham wrote: > The delay values should be managed correctly. Not the dealys. > > Correct accordingly, but I also hope we'll resolve this > task soon too. Maybe the second part shouldn't be in the commit message > > Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > --- > src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp > index c02c7cf374e9..2fee84e56d4d 100644 > --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp > +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp > @@ -1103,7 +1103,7 @@ int PipelineHandlerRkISP1::createCamera(MediaEntity *sensor) > data->properties_ = data->sensor_->properties(); > > /* > - * \todo Read dealy values from the sensor itself or from a > + * \todo Read delay values from the sensor itself or from a > * a sensor database. For now use generic values taken from > * the Raspberry Pi and listed as generic values. > */ > -- > 2.46.0 >
Quoting Jacopo Mondi (2024-09-27 14:48:45) > On Mon, Sep 16, 2024 at 04:02:39PM GMT, Kieran Bingham wrote: > > The delay values should be managed correctly. Not the dealys. > > > > Correct accordingly, but I also hope we'll resolve this > > task soon too. > > Maybe the second part shouldn't be in the commit message Happy to drop the second paragraph. This was only a drive by commit while I was here. > > > > > Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > > --- > > src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp > > index c02c7cf374e9..2fee84e56d4d 100644 > > --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp > > +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp > > @@ -1103,7 +1103,7 @@ int PipelineHandlerRkISP1::createCamera(MediaEntity *sensor) > > data->properties_ = data->sensor_->properties(); > > > > /* > > - * \todo Read dealy values from the sensor itself or from a > > + * \todo Read delay values from the sensor itself or from a > > * a sensor database. For now use generic values taken from > > * the Raspberry Pi and listed as generic values. > > */ > > -- > > 2.46.0 > >
diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp index c02c7cf374e9..2fee84e56d4d 100644 --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp @@ -1103,7 +1103,7 @@ int PipelineHandlerRkISP1::createCamera(MediaEntity *sensor) data->properties_ = data->sensor_->properties(); /* - * \todo Read dealy values from the sensor itself or from a + * \todo Read delay values from the sensor itself or from a * a sensor database. For now use generic values taken from * the Raspberry Pi and listed as generic values. */
The delay values should be managed correctly. Not the dealys. Correct accordingly, but I also hope we'll resolve this task soon too. Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com> --- src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)