| Message ID | 20240902154212.1281257-15-mzamazal@redhat.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series |
|
| Related | show |
Hi Milan, Thank you for the patch. On Mon, Sep 02, 2024 at 05:42:07PM +0200, Milan Zamazal wrote: > Let's add direct includes for classes currently included indirectly, > through other header files. > > Signed-off-by: Milan Zamazal <mzamazal@redhat.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > src/libcamera/base/event_dispatcher_poll.cpp | 1 + > src/libcamera/camera.cpp | 5 +++++ > src/libcamera/formats.cpp | 2 ++ > src/libcamera/ipa_data_serializer.cpp | 2 ++ > src/libcamera/stream.cpp | 3 +++ > 5 files changed, 13 insertions(+) > > diff --git a/src/libcamera/base/event_dispatcher_poll.cpp b/src/libcamera/base/event_dispatcher_poll.cpp > index 194d7bd2..52bfb34e 100644 > --- a/src/libcamera/base/event_dispatcher_poll.cpp > +++ b/src/libcamera/base/event_dispatcher_poll.cpp > @@ -13,6 +13,7 @@ > #include <string.h> > #include <sys/eventfd.h> > #include <unistd.h> > +#include <vector> > > #include <libcamera/base/event_notifier.h> > #include <libcamera/base/log.h> > diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp > index 9d1ae696..a86f552a 100644 > --- a/src/libcamera/camera.cpp > +++ b/src/libcamera/camera.cpp > @@ -9,6 +9,11 @@ > > #include <array> > #include <atomic> > +#include <ios> > +#include <memory> > +#include <optional> > +#include <set> > +#include <sstream> > > #include <libcamera/base/log.h> > #include <libcamera/base/thread.h> > diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp > index 3ee89590..dbefb094 100644 > --- a/src/libcamera/formats.cpp > +++ b/src/libcamera/formats.cpp > @@ -7,6 +7,8 @@ > > #include "libcamera/internal/formats.h" > > +#include <map> > + > #include <libcamera/base/log.h> > #include <libcamera/base/utils.h> > > diff --git a/src/libcamera/ipa_data_serializer.cpp b/src/libcamera/ipa_data_serializer.cpp > index 3e9bef08..f6dd7e6f 100644 > --- a/src/libcamera/ipa_data_serializer.cpp > +++ b/src/libcamera/ipa_data_serializer.cpp > @@ -11,6 +11,8 @@ > > #include <libcamera/base/log.h> > > +#include "libcamera/internal/byte_stream_buffer.h" > + > /** > * \file ipa_data_serializer.h > * \brief IPA Data Serializer > diff --git a/src/libcamera/stream.cpp b/src/libcamera/stream.cpp > index e70688f6..33018ec1 100644 > --- a/src/libcamera/stream.cpp > +++ b/src/libcamera/stream.cpp > @@ -10,6 +10,9 @@ > #include <algorithm> > #include <array> > #include <limits.h> > +#include <ostream> > +#include <string> > +#include <vector> > > #include <libcamera/request.h> >
diff --git a/src/libcamera/base/event_dispatcher_poll.cpp b/src/libcamera/base/event_dispatcher_poll.cpp index 194d7bd2..52bfb34e 100644 --- a/src/libcamera/base/event_dispatcher_poll.cpp +++ b/src/libcamera/base/event_dispatcher_poll.cpp @@ -13,6 +13,7 @@ #include <string.h> #include <sys/eventfd.h> #include <unistd.h> +#include <vector> #include <libcamera/base/event_notifier.h> #include <libcamera/base/log.h> diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp index 9d1ae696..a86f552a 100644 --- a/src/libcamera/camera.cpp +++ b/src/libcamera/camera.cpp @@ -9,6 +9,11 @@ #include <array> #include <atomic> +#include <ios> +#include <memory> +#include <optional> +#include <set> +#include <sstream> #include <libcamera/base/log.h> #include <libcamera/base/thread.h> diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp index 3ee89590..dbefb094 100644 --- a/src/libcamera/formats.cpp +++ b/src/libcamera/formats.cpp @@ -7,6 +7,8 @@ #include "libcamera/internal/formats.h" +#include <map> + #include <libcamera/base/log.h> #include <libcamera/base/utils.h> diff --git a/src/libcamera/ipa_data_serializer.cpp b/src/libcamera/ipa_data_serializer.cpp index 3e9bef08..f6dd7e6f 100644 --- a/src/libcamera/ipa_data_serializer.cpp +++ b/src/libcamera/ipa_data_serializer.cpp @@ -11,6 +11,8 @@ #include <libcamera/base/log.h> +#include "libcamera/internal/byte_stream_buffer.h" + /** * \file ipa_data_serializer.h * \brief IPA Data Serializer diff --git a/src/libcamera/stream.cpp b/src/libcamera/stream.cpp index e70688f6..33018ec1 100644 --- a/src/libcamera/stream.cpp +++ b/src/libcamera/stream.cpp @@ -10,6 +10,9 @@ #include <algorithm> #include <array> #include <limits.h> +#include <ostream> +#include <string> +#include <vector> #include <libcamera/request.h>
Let's add direct includes for classes currently included indirectly, through other header files. Signed-off-by: Milan Zamazal <mzamazal@redhat.com> --- src/libcamera/base/event_dispatcher_poll.cpp | 1 + src/libcamera/camera.cpp | 5 +++++ src/libcamera/formats.cpp | 2 ++ src/libcamera/ipa_data_serializer.cpp | 2 ++ src/libcamera/stream.cpp | 3 +++ 5 files changed, 13 insertions(+)