| Message ID | 20240902154212.1281257-10-mzamazal@redhat.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series |
|
| Related | show |
Hi Milan, Thank you for the patch. On Mon, Sep 02, 2024 at 05:42:02PM +0200, Milan Zamazal wrote: > The includes that are not used can be removed. Also, some directly used > includes not listed are added. > > Signed-off-by: Milan Zamazal <mzamazal@redhat.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > src/libcamera/v4l2_device.cpp | 2 -- > src/libcamera/v4l2_subdevice.cpp | 1 - > src/libcamera/v4l2_videodevice.cpp | 1 - > src/v4l2/v4l2_camera.h | 3 ++- > src/v4l2/v4l2_camera_proxy.cpp | 1 - > src/v4l2/v4l2_compat.cpp | 1 - > src/v4l2/v4l2_compat_manager.cpp | 1 - > 7 files changed, 2 insertions(+), 8 deletions(-) > > diff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp > index 4a2048cf..68add4f2 100644 > --- a/src/libcamera/v4l2_device.cpp > +++ b/src/libcamera/v4l2_device.cpp > @@ -8,8 +8,6 @@ > #include "libcamera/internal/v4l2_device.h" > > #include <fcntl.h> > -#include <iomanip> > -#include <limits.h> > #include <map> > #include <stdlib.h> > #include <string.h> > diff --git a/src/libcamera/v4l2_subdevice.cpp b/src/libcamera/v4l2_subdevice.cpp > index 82824433..6eaa8f01 100644 > --- a/src/libcamera/v4l2_subdevice.cpp > +++ b/src/libcamera/v4l2_subdevice.cpp > @@ -8,7 +8,6 @@ > #include "libcamera/internal/v4l2_subdevice.h" > > #include <fcntl.h> > -#include <iomanip> > #include <regex> > #include <sstream> > #include <string.h> > diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp > index 6f32521f..76742e18 100644 > --- a/src/libcamera/v4l2_videodevice.cpp > +++ b/src/libcamera/v4l2_videodevice.cpp > @@ -10,7 +10,6 @@ > #include <algorithm> > #include <array> > #include <fcntl.h> > -#include <iomanip> > #include <sstream> > #include <string.h> > #include <sys/ioctl.h> > diff --git a/src/v4l2/v4l2_camera.h b/src/v4l2/v4l2_camera.h > index 278cc33e..9a0b0455 100644 > --- a/src/v4l2/v4l2_camera.h > +++ b/src/v4l2/v4l2_camera.h > @@ -8,7 +8,8 @@ > #pragma once > > #include <deque> > -#include <utility> > +#include <memory> > +#include <vector> > > #include <libcamera/base/mutex.h> > #include <libcamera/base/semaphore.h> > diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp > index 3f7c00a2..a020a2b0 100644 > --- a/src/v4l2/v4l2_camera_proxy.cpp > +++ b/src/v4l2/v4l2_camera_proxy.cpp > @@ -8,7 +8,6 @@ > #include "v4l2_camera_proxy.h" > > #include <algorithm> > -#include <array> > #include <errno.h> > #include <numeric> > #include <set> > diff --git a/src/v4l2/v4l2_compat.cpp b/src/v4l2/v4l2_compat.cpp > index 6c9dca72..ff833f57 100644 > --- a/src/v4l2/v4l2_compat.cpp > +++ b/src/v4l2/v4l2_compat.cpp > @@ -8,7 +8,6 @@ > #include "v4l2_compat_manager.h" > > #include <assert.h> > -#include <errno.h> > #include <fcntl.h> > #include <stdarg.h> > #include <sys/ioctl.h> > diff --git a/src/v4l2/v4l2_compat_manager.cpp b/src/v4l2/v4l2_compat_manager.cpp > index 6a00afb5..f53fb300 100644 > --- a/src/v4l2/v4l2_compat_manager.cpp > +++ b/src/v4l2/v4l2_compat_manager.cpp > @@ -10,7 +10,6 @@ > #include <dlfcn.h> > #include <fcntl.h> > #include <map> > -#include <stdarg.h> > #include <string.h> > #include <sys/eventfd.h> > #include <sys/mman.h>
diff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp index 4a2048cf..68add4f2 100644 --- a/src/libcamera/v4l2_device.cpp +++ b/src/libcamera/v4l2_device.cpp @@ -8,8 +8,6 @@ #include "libcamera/internal/v4l2_device.h" #include <fcntl.h> -#include <iomanip> -#include <limits.h> #include <map> #include <stdlib.h> #include <string.h> diff --git a/src/libcamera/v4l2_subdevice.cpp b/src/libcamera/v4l2_subdevice.cpp index 82824433..6eaa8f01 100644 --- a/src/libcamera/v4l2_subdevice.cpp +++ b/src/libcamera/v4l2_subdevice.cpp @@ -8,7 +8,6 @@ #include "libcamera/internal/v4l2_subdevice.h" #include <fcntl.h> -#include <iomanip> #include <regex> #include <sstream> #include <string.h> diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp index 6f32521f..76742e18 100644 --- a/src/libcamera/v4l2_videodevice.cpp +++ b/src/libcamera/v4l2_videodevice.cpp @@ -10,7 +10,6 @@ #include <algorithm> #include <array> #include <fcntl.h> -#include <iomanip> #include <sstream> #include <string.h> #include <sys/ioctl.h> diff --git a/src/v4l2/v4l2_camera.h b/src/v4l2/v4l2_camera.h index 278cc33e..9a0b0455 100644 --- a/src/v4l2/v4l2_camera.h +++ b/src/v4l2/v4l2_camera.h @@ -8,7 +8,8 @@ #pragma once #include <deque> -#include <utility> +#include <memory> +#include <vector> #include <libcamera/base/mutex.h> #include <libcamera/base/semaphore.h> diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp index 3f7c00a2..a020a2b0 100644 --- a/src/v4l2/v4l2_camera_proxy.cpp +++ b/src/v4l2/v4l2_camera_proxy.cpp @@ -8,7 +8,6 @@ #include "v4l2_camera_proxy.h" #include <algorithm> -#include <array> #include <errno.h> #include <numeric> #include <set> diff --git a/src/v4l2/v4l2_compat.cpp b/src/v4l2/v4l2_compat.cpp index 6c9dca72..ff833f57 100644 --- a/src/v4l2/v4l2_compat.cpp +++ b/src/v4l2/v4l2_compat.cpp @@ -8,7 +8,6 @@ #include "v4l2_compat_manager.h" #include <assert.h> -#include <errno.h> #include <fcntl.h> #include <stdarg.h> #include <sys/ioctl.h> diff --git a/src/v4l2/v4l2_compat_manager.cpp b/src/v4l2/v4l2_compat_manager.cpp index 6a00afb5..f53fb300 100644 --- a/src/v4l2/v4l2_compat_manager.cpp +++ b/src/v4l2/v4l2_compat_manager.cpp @@ -10,7 +10,6 @@ #include <dlfcn.h> #include <fcntl.h> #include <map> -#include <stdarg.h> #include <string.h> #include <sys/eventfd.h> #include <sys/mman.h>
The includes that are not used can be removed. Also, some directly used includes not listed are added. Signed-off-by: Milan Zamazal <mzamazal@redhat.com> --- src/libcamera/v4l2_device.cpp | 2 -- src/libcamera/v4l2_subdevice.cpp | 1 - src/libcamera/v4l2_videodevice.cpp | 1 - src/v4l2/v4l2_camera.h | 3 ++- src/v4l2/v4l2_camera_proxy.cpp | 1 - src/v4l2/v4l2_compat.cpp | 1 - src/v4l2/v4l2_compat_manager.cpp | 1 - 7 files changed, 2 insertions(+), 8 deletions(-)