| Message ID | 20240830152721.1420313-19-mzamazal@redhat.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series |
|
| Related | show |
Hi Milan, Thank you for the patch. On Fri, Aug 30, 2024 at 05:27:15PM +0200, Milan Zamazal wrote: > Let's add direct includes for classes currently included indirectly, > through other header files. > > Signed-off-by: Milan Zamazal <mzamazal@redhat.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > include/libcamera/internal/request.h | 1 + > include/libcamera/logging.h | 2 ++ > 2 files changed, 3 insertions(+) > > diff --git a/include/libcamera/internal/request.h b/include/libcamera/internal/request.h > index f5d98069..4e7d05b1 100644 > --- a/include/libcamera/internal/request.h > +++ b/include/libcamera/internal/request.h > @@ -10,6 +10,7 @@ > #include <chrono> > #include <map> > #include <memory> > +#include <unordered_set> > > #include <libcamera/base/event_notifier.h> > #include <libcamera/base/timer.h> > diff --git a/include/libcamera/logging.h b/include/libcamera/logging.h > index e334d87b..e1c6341c 100644 > --- a/include/libcamera/logging.h > +++ b/include/libcamera/logging.h > @@ -7,6 +7,8 @@ > > #pragma once > > +#include <ostream> > + > namespace libcamera { > > enum LoggingTarget {
diff --git a/include/libcamera/internal/request.h b/include/libcamera/internal/request.h index f5d98069..4e7d05b1 100644 --- a/include/libcamera/internal/request.h +++ b/include/libcamera/internal/request.h @@ -10,6 +10,7 @@ #include <chrono> #include <map> #include <memory> +#include <unordered_set> #include <libcamera/base/event_notifier.h> #include <libcamera/base/timer.h> diff --git a/include/libcamera/logging.h b/include/libcamera/logging.h index e334d87b..e1c6341c 100644 --- a/include/libcamera/logging.h +++ b/include/libcamera/logging.h @@ -7,6 +7,8 @@ #pragma once +#include <ostream> + namespace libcamera { enum LoggingTarget {
Let's add direct includes for classes currently included indirectly, through other header files. Signed-off-by: Milan Zamazal <mzamazal@redhat.com> --- include/libcamera/internal/request.h | 1 + include/libcamera/logging.h | 2 ++ 2 files changed, 3 insertions(+)