[v2,02/20] libcamera: ipu3: Remove unused includes
diff mbox series

Message ID 20240830152721.1420313-3-mzamazal@redhat.com
State Accepted
Headers show
Series
  • Remove unused includes
Related show

Commit Message

Milan Zamazal Aug. 30, 2024, 3:26 p.m. UTC 
The includes that are not used can be removed.

Signed-off-by: Milan Zamazal <mzamazal@redhat.com>
---
 src/ipa/ipu3/algorithms/af.cpp       | 3 ---
 src/ipa/ipu3/algorithms/agc.cpp      | 1 -
 src/ipa/ipu3/algorithms/blc.cpp      | 2 --
 src/ipa/ipu3/ipu3.cpp                | 5 -----
 src/libcamera/pipeline/ipu3/ipu3.cpp | 1 -
 5 files changed, 12 deletions(-)

Comments

Laurent Pinchart Aug. 30, 2024, 11:32 p.m. UTC | #1 
Hi Milan,

Thank you for the patch.

On Fri, Aug 30, 2024 at 05:26:59PM +0200, Milan Zamazal wrote:
> The includes that are not used can be removed.
> 
> Signed-off-by: Milan Zamazal <mzamazal@redhat.com>
> ---
>  src/ipa/ipu3/algorithms/af.cpp       | 3 ---
>  src/ipa/ipu3/algorithms/agc.cpp      | 1 -
>  src/ipa/ipu3/algorithms/blc.cpp      | 2 --
>  src/ipa/ipu3/ipu3.cpp                | 5 -----
>  src/libcamera/pipeline/ipu3/ipu3.cpp | 1 -
>  5 files changed, 12 deletions(-)
> 
> diff --git a/src/ipa/ipu3/algorithms/af.cpp b/src/ipa/ipu3/algorithms/af.cpp
> index 29eb7355..cf68fb59 100644
> --- a/src/ipa/ipu3/algorithms/af.cpp
> +++ b/src/ipa/ipu3/algorithms/af.cpp
> @@ -11,7 +11,6 @@
>  #include <chrono>
>  #include <cmath>
>  #include <fcntl.h>
> -#include <numeric>
>  #include <sys/ioctl.h>
>  #include <sys/stat.h>
>  #include <sys/types.h>
> @@ -23,8 +22,6 @@
>  
>  #include <libcamera/ipa/core_ipa_interface.h>
>  
> -#include "libipa/histogram.h"
> -
>  /**
>   * \file af.h
>   */
> diff --git a/src/ipa/ipu3/algorithms/agc.cpp b/src/ipa/ipu3/algorithms/agc.cpp
> index 0e0114f6..3378c4fd 100644
> --- a/src/ipa/ipu3/algorithms/agc.cpp
> +++ b/src/ipa/ipu3/algorithms/agc.cpp
> @@ -9,7 +9,6 @@
>  
>  #include <algorithm>
>  #include <chrono>
> -#include <cmath>
>  
>  #include <libcamera/base/log.h>
>  #include <libcamera/base/utils.h>
> diff --git a/src/ipa/ipu3/algorithms/blc.cpp b/src/ipa/ipu3/algorithms/blc.cpp
> index 257f40e2..fa4b9272 100644
> --- a/src/ipa/ipu3/algorithms/blc.cpp
> +++ b/src/ipa/ipu3/algorithms/blc.cpp
> @@ -7,8 +7,6 @@
>  
>  #include "blc.h"
>  
> -#include <string.h>
> -
>  /**
>   * \file blc.h
>   * \brief IPU3 Black Level Correction control
> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp
> index cdcdf1fb..656c51fc 100644
> --- a/src/ipa/ipu3/ipu3.cpp
> +++ b/src/ipa/ipu3/ipu3.cpp
> @@ -32,12 +32,7 @@
>  #include "libcamera/internal/mapped_framebuffer.h"
>  #include "libcamera/internal/yaml_parser.h"
>  
> -#include "algorithms/af.h"
>  #include "algorithms/agc.h"

agc.h isn't used, but you need to include module.h.

With that,

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> -#include "algorithms/algorithm.h"
> -#include "algorithms/awb.h"
> -#include "algorithms/blc.h"
> -#include "algorithms/tone_mapping.h"
>  #include "libipa/camera_sensor_helper.h"
>  
>  #include "ipa_context.h"
> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp
> index 2071c338..29172f34 100644
> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp
> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp
> @@ -6,7 +6,6 @@
>   */
>  
>  #include <algorithm>
> -#include <iomanip>
>  #include <memory>
>  #include <queue>
>  #include <vector>

Patch
diff mbox series 

diff --git a/src/ipa/ipu3/algorithms/af.cpp b/src/ipa/ipu3/algorithms/af.cpp
index 29eb7355..cf68fb59 100644
--- a/src/ipa/ipu3/algorithms/af.cpp
+++ b/src/ipa/ipu3/algorithms/af.cpp
@@ -11,7 +11,6 @@ 
 #include <chrono>
 #include <cmath>
 #include <fcntl.h>
-#include <numeric>
 #include <sys/ioctl.h>
 #include <sys/stat.h>
 #include <sys/types.h>
@@ -23,8 +22,6 @@ 
 
 #include <libcamera/ipa/core_ipa_interface.h>
 
-#include "libipa/histogram.h"
-
 /**
  * \file af.h
  */
diff --git a/src/ipa/ipu3/algorithms/agc.cpp b/src/ipa/ipu3/algorithms/agc.cpp
index 0e0114f6..3378c4fd 100644
--- a/src/ipa/ipu3/algorithms/agc.cpp
+++ b/src/ipa/ipu3/algorithms/agc.cpp
@@ -9,7 +9,6 @@ 
 
 #include <algorithm>
 #include <chrono>
-#include <cmath>
 
 #include <libcamera/base/log.h>
 #include <libcamera/base/utils.h>
diff --git a/src/ipa/ipu3/algorithms/blc.cpp b/src/ipa/ipu3/algorithms/blc.cpp
index 257f40e2..fa4b9272 100644
--- a/src/ipa/ipu3/algorithms/blc.cpp
+++ b/src/ipa/ipu3/algorithms/blc.cpp
@@ -7,8 +7,6 @@ 
 
 #include "blc.h"
 
-#include <string.h>
-
 /**
  * \file blc.h
  * \brief IPU3 Black Level Correction control
diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp
index cdcdf1fb..656c51fc 100644
--- a/src/ipa/ipu3/ipu3.cpp
+++ b/src/ipa/ipu3/ipu3.cpp
@@ -32,12 +32,7 @@ 
 #include "libcamera/internal/mapped_framebuffer.h"
 #include "libcamera/internal/yaml_parser.h"
 
-#include "algorithms/af.h"
 #include "algorithms/agc.h"
-#include "algorithms/algorithm.h"
-#include "algorithms/awb.h"
-#include "algorithms/blc.h"
-#include "algorithms/tone_mapping.h"
 #include "libipa/camera_sensor_helper.h"
 
 #include "ipa_context.h"
diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp
index 2071c338..29172f34 100644
--- a/src/libcamera/pipeline/ipu3/ipu3.cpp
+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp
@@ -6,7 +6,6 @@ 
  */
 
 #include <algorithm>
-#include <iomanip>
 #include <memory>
 #include <queue>
 #include <vector>