[3/3] libcamera: pipeline: simple: Use MediaLink string helper
diff mbox series

Message ID 20240815210925.4172287-4-kieran.bingham@ideasonboard.com
State Superseded
Headers show
Series
  • MediaLink: Provide a string representation
Related show

Commit Message

Kieran Bingham Aug. 15, 2024, 9:09 p.m. UTC 
Replace the open-coded implementation of a link representation
with the operator<< overload string representation to simplify
the code and unify appearance of reporting MediaLinks.

Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
---
 src/libcamera/pipeline/simple/simple.cpp | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

Comments

Laurent Pinchart Aug. 15, 2024, 9:18 p.m. UTC | #1 
On Thu, Aug 15, 2024 at 10:09:25PM +0100, Kieran Bingham wrote:
> Replace the open-coded implementation of a link representation
> with the operator<< overload string representation to simplify
> the code and unify appearance of reporting MediaLinks.
> 
> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  src/libcamera/pipeline/simple/simple.cpp | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp
> index 1e7ec7d97255..2d205e9925ef 100644
> --- a/src/libcamera/pipeline/simple/simple.cpp
> +++ b/src/libcamera/pipeline/simple/simple.cpp
> @@ -774,11 +774,8 @@ int SimpleCameraData::setupFormats(V4L2SubdeviceFormat *format,
>  		}
>  
>  		LOG(SimplePipeline, Debug)
> -			<< "Link '" << source->entity()->name()
> -			<< "':" << source->index()
> -			<< " -> '" << sink->entity()->name()
> -			<< "':" << sink->index()
> -			<< " configured with format " << *format;
> +			<< "Link " << *link << ": configured with format "
> +			<< *format;
>  	}
>  
>  	return 0;
Stefan Klug Sept. 12, 2024, 8:56 a.m. UTC | #2 
Hi Kieran,

Thank you for the patch.

On Thu, Aug 15, 2024 at 10:09:25PM +0100, Kieran Bingham wrote:
> Replace the open-coded implementation of a link representation
> with the operator<< overload string representation to simplify
> the code and unify appearance of reporting MediaLinks.
> 
> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

Reviewed-by: Stefan Klug <stefan.klug@ideasonboard.com>

Regards,
Stefan

> ---
>  src/libcamera/pipeline/simple/simple.cpp | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp
> index 1e7ec7d97255..2d205e9925ef 100644
> --- a/src/libcamera/pipeline/simple/simple.cpp
> +++ b/src/libcamera/pipeline/simple/simple.cpp
> @@ -774,11 +774,8 @@ int SimpleCameraData::setupFormats(V4L2SubdeviceFormat *format,
>  		}
>  
>  		LOG(SimplePipeline, Debug)
> -			<< "Link '" << source->entity()->name()
> -			<< "':" << source->index()
> -			<< " -> '" << sink->entity()->name()
> -			<< "':" << sink->index()
> -			<< " configured with format " << *format;
> +			<< "Link " << *link << ": configured with format "
> +			<< *format;
>  	}
>  
>  	return 0;
> -- 
> 2.34.1
>

Patch
diff mbox series 

diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp
index 1e7ec7d97255..2d205e9925ef 100644
--- a/src/libcamera/pipeline/simple/simple.cpp
+++ b/src/libcamera/pipeline/simple/simple.cpp
@@ -774,11 +774,8 @@  int SimpleCameraData::setupFormats(V4L2SubdeviceFormat *format,
 		}
 
 		LOG(SimplePipeline, Debug)
-			<< "Link '" << source->entity()->name()
-			<< "':" << source->index()
-			<< " -> '" << sink->entity()->name()
-			<< "':" << sink->index()
-			<< " configured with format " << *format;
+			<< "Link " << *link << ": configured with format "
+			<< *format;
 	}
 
 	return 0;