[v4,6/6] utils: tuning: rkisp1: Replace static AWB with new AWB module

20899 diff mbox series

The rkisp1 tuner used a static module to insert the AWB algorithm into
the tuning file. Replace that with the new AWB module.

Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
---
 utils/tuning/rkisp1.py | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

On Tue, Aug 13, 2024 at 10:44:23AM +0200, Stefan Klug wrote:
> The rkisp1 tuner used a static module to insert the AWB algorithm into
> the tuning file. Replace that with the new AWB module.
> 
> Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>
> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>

> ---
>  utils/tuning/rkisp1.py | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/utils/tuning/rkisp1.py b/utils/tuning/rkisp1.py
> index f5c42a61d15e..9f40fd8bd63b 100755
> --- a/utils/tuning/rkisp1.py
> +++ b/utils/tuning/rkisp1.py
> @@ -2,6 +2,7 @@
>  # SPDX-License-Identifier: GPL-2.0-or-later
>  #
>  # Copyright (C) 2022, Paul Elder <paul.elder@ideasonboard.com>
> +# Copyright (C) 2024, Ideas On Board
>  #
>  # Tuning script for rkisp1
>  
> @@ -14,13 +15,14 @@ from libtuning.parsers import YamlParser
>  from libtuning.generators import YamlOutput
>  from libtuning.modules.lsc import LSCRkISP1
>  from libtuning.modules.agc import AGCRkISP1
> +from libtuning.modules.awb import AWBRkISP1
>  from libtuning.modules.ccm import CCMRkISP1
>  from libtuning.modules.static import StaticModule
>  
>  coloredlogs.install(level=logging.INFO, fmt='%(name)s %(levelname)s %(message)s')
>  
>  agc = AGCRkISP1(debug=[lt.Debug.Plot])
> -awb = StaticModule('Awb')
> +awb = AWBRkISP1(debug=[lt.Debug.Plot])
>  blc = StaticModule('BlackLevelCorrection')
>  ccm = CCMRkISP1(debug=[lt.Debug.Plot])
>  color_processing = StaticModule('ColorProcessing')
> -- 
> 2.43.0
>

Hi Stefan,

Thank you for the patch.

On Tue, Aug 13, 2024 at 10:44:23AM +0200, Stefan Klug wrote:
> The rkisp1 tuner used a static module to insert the AWB algorithm into
> the tuning file. Replace that with the new AWB module.
> 
> Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>
> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

I would probably move the three tuning tool patches to the beginning of
the series, I had to read them before reviewing 2/6 and 3/6 to
understand what was happening.

> ---
>  utils/tuning/rkisp1.py | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/utils/tuning/rkisp1.py b/utils/tuning/rkisp1.py
> index f5c42a61d15e..9f40fd8bd63b 100755
> --- a/utils/tuning/rkisp1.py
> +++ b/utils/tuning/rkisp1.py
> @@ -2,6 +2,7 @@
>  # SPDX-License-Identifier: GPL-2.0-or-later
>  #
>  # Copyright (C) 2022, Paul Elder <paul.elder@ideasonboard.com>
> +# Copyright (C) 2024, Ideas On Board
>  #
>  # Tuning script for rkisp1
>  
> @@ -14,13 +15,14 @@ from libtuning.parsers import YamlParser
>  from libtuning.generators import YamlOutput
>  from libtuning.modules.lsc import LSCRkISP1
>  from libtuning.modules.agc import AGCRkISP1
> +from libtuning.modules.awb import AWBRkISP1
>  from libtuning.modules.ccm import CCMRkISP1
>  from libtuning.modules.static import StaticModule
>  
>  coloredlogs.install(level=logging.INFO, fmt='%(name)s %(levelname)s %(message)s')
>  
>  agc = AGCRkISP1(debug=[lt.Debug.Plot])
> -awb = StaticModule('Awb')
> +awb = AWBRkISP1(debug=[lt.Debug.Plot])
>  blc = StaticModule('BlackLevelCorrection')
>  ccm = CCMRkISP1(debug=[lt.Debug.Plot])
>  color_processing = StaticModule('ColorProcessing')